OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][RFC] Cleanup in namespaces unsharing
Re: [PATCH][RFC] Cleanup in namespaces unsharing [message #13943 is a reply to message #13942] Fri, 08 June 2007 09:35 Go to previous messageGo to previous message
Cedric Le Goater is currently offline  Cedric Le Goater
Messages: 443
Registered: February 2006
Senior Member
Pavel Emelianov wrote:
> Currently we have two funtions to copy the namespaces:
> copy_namespaces() and unshare_nsproxy_namespaces(). The
> second one checks for unsupported functionality with
>
> #ifndef CONFIG_IPC_NS
> if (unshare_flags & CLONE_NEWIPC)
> return -EINVAL;
> #endif
>
> -like constructions, while the first one does not. One
> of the side effects of this is that clone() with the
> CLONE_NEWXXX set will return 0 if the kernel doesn't
> support XXX namespaces thus confusing the user-level.
>
> The proposal is to make these calls clean from the ifdefs
> and move these checks into each namespaces' stubs. This
> will make the code cleaner and (!) return -EINVAL from
> fork() in case the desired namespaces are not supported.
>
> Did I miss something in the design or this patch worth merging?

I've sent a more brutal patch in the past removing CONFIG_IPC_NS
and CONFIG_UTS_NS. Might be a better idea ?

Let me refresh it and resend.

C.

Report message to a moderator

[Message index]
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH -mm] remove CONFIG_UTS_NS and CONFIG_IPC_NS
Next Topic: [PATCH -mm 2/2] user namespace : add unshare
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Fri Dec 05 23:55:05 GMT 2025

Total time taken to generate the page: 0.11263 seconds
Powered by FUDforum Powered by Virtuozzo Containers