OpenVZ Forum: Devel » [PATCH 0/8] RSS controller based on process containers (v3)

Home » Mailing lists » Devel » [PATCH 0/8] RSS controller based on process containers (v3)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner [message #13655 is a reply to message #13652]

Fri, 01 June 2007 07:36

Pavel Emelianov
Messages: 1149
Registered: September 2006

Senior Member

Balbir Singh wrote:
> Andrew Morton wrote:
>>> + nr_reclaimed += shrink_zones(priority, zones, sc);
>>> + if (sc->cnt == NULL)
>>> + shrink_slab(sc->nr_scanned, gfp_mask, lru_pages);
>> We don't we shrink slab if called to shrink a container.
>>
>> This is a fundamental design decision, and a design shortcoming. A full
>> discussion of this is absolutely appropriate to the patch changelog.
>> Please don't just hide stuff like this in the patch and leave people
>> wondering, or ignorant.
>
> Yes, we don't because we do not account for slab usage right now. We account
> only for memory allocated to user space. A good fat comment will help here.
>
>

I have already added the comment. But the problem is not in that we
do not account for kernel memory. Shrinking slabs won't unmap any
pages from user-space and thus won't help user to charge more. This
will only make kernel suffer from re-creation of objects.

Thanks,
Pavel.

Report message to a moderator

[Message index]

		[PATCH 0/8] RSS controller based on process containers (v3) By: Pavel Emelianov on Wed, 30 May 2007 15:24
		[PATCH 4/8] RSS container core By: Pavel Emelianov on Wed, 30 May 2007 15:27
		Re: [PATCH 4/8] RSS container core By: Andrew Morton on Wed, 30 May 2007 21:46
		Re: [PATCH 4/8] RSS container core By: Pavel Emelianov on Thu, 31 May 2007 08:57
		[PATCH 5/8] RSS accounting hooks over the code By: Pavel Emelianov on Wed, 30 May 2007 15:29
		Re: [PATCH 5/8] RSS accounting hooks over the code By: Andrew Morton on Wed, 30 May 2007 21:46
		Re: [PATCH 5/8] RSS accounting hooks over the code By: Balbir Singh on Fri, 01 June 2007 06:48
		[PATCH 6/8] Per container OOM killer By: Pavel Emelianov on Wed, 30 May 2007 15:31
		[PATCH 7/8] Scanner changes needed to implement per-container scanner By: Pavel Emelianov on Wed, 30 May 2007 15:35
		Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner By: Andrew Morton on Wed, 30 May 2007 21:46
		Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner By: Balbir Singh on Fri, 01 June 2007 06:50
		Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner By: Pavel Emelianov on Fri, 01 June 2007 07:36
		Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner By: Balbir Singh on Fri, 01 June 2007 07:38
		[PATCH 8/8] Per-container pages reclamation By: Pavel Emelianov on Wed, 30 May 2007 15:38
		Re: [PATCH 8/8] Per-container pages reclamation By: Andrew Morton on Wed, 30 May 2007 21:47
		Re: [PATCH 8/8] Per-container pages reclamation By: Vaidyanathan Srinivas on Thu, 31 May 2007 08:22
		Re: [PATCH 8/8] Per-container pages reclamation By: Balbir Singh on Thu, 31 May 2007 09:22
		Re: [PATCH 8/8] Per-container pages reclamation By: Pavel Emelianov on Fri, 01 June 2007 09:23
		Re: [PATCH 8/8] Per-container pages reclamation By: Balbir Singh on Fri, 01 June 2007 09:23
		Re: [PATCH 8/8] Per-container pages reclamation By: Pavel Emelianov on Thu, 31 May 2007 10:31
		Re: [PATCH 8/8] Per-container pages reclamation By: Andrew Morton on Thu, 31 May 2007 17:58
		Re: [PATCH 8/8] Per-container pages reclamation By: Pavel Emelianov on Fri, 01 June 2007 07:40
		Re: [PATCH 8/8] Per-container pages reclamation By: Andrew Morton on Fri, 01 June 2007 07:49
		Re: [PATCH 8/8] Per-container pages reclamation By: Balbir Singh on Fri, 01 June 2007 07:02
		Re: [PATCH 8/8] Per-container pages reclamation By: Pavel Emelianov on Fri, 01 June 2007 07:47

Previous Topic:	[PATCH] Report that kernel is tainted if there were an OOPS before (v2)
Next Topic:	[DEVEL] [PATCH 2.6.18] Fix syslog() issues in LTP

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Aug 24 09:20:17 GMT 2026

Total time taken to generate the page: 0.95418 seconds