OpenVZ Forum: Devel » [PATCH 0/13] Pid namespaces (OpenVZ view)

Home » Mailing lists » Devel » [PATCH 0/13] Pid namespaces (OpenVZ view)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 2/13] Small preparations for namespaces [message #13401 is a reply to message #13395]

Fri, 25 May 2007 13:55

serue
Messages: 750
Registered: February 2006

Senior Member

Quoting Pavel Emelianov (xemul@openvz.org):
> Serge E. Hallyn wrote:
> > Quoting Pavel Emelianov (xemul@openvz.org):
> >> Serge E. Hallyn wrote:
> >>> Quoting Pavel Emelianov (xemul@openvz.org):
> >>>> This includes #ifdefs in get/put_pid_ns and rewriting
> >>>> the child_reaper() function to the more logical view.
> >>>>
> >>>> This doesn't fit logically into any other patch so
> >>>> I decided to make it separate.
> >>>>
> >>>> Signed-off-by: Pavel Emelianov <xemul@openvz.org>
> >>>>
> >>>> ---
> >>>>
> >>>> diff --git a/include/linux/pid_namespace.h b/include/linux/pid_namespace.h
> >>>> index 169c6c2..7af7191 100644
> >>>> --- a/include/linux/pid_namespace.h
> >>>> +++ b/include/linux/pid_namespace.h
> >>>> @@ -26,7 +26,9 @@ extern struct pid_namespace init_pid_ns;
> >>>>
> >>>> static inline void get_pid_ns(struct pid_namespace *ns)
> >>>> {
> >>>> +#ifdef CONFIG_PID_NS
> >>>> kref_get(&ns->kref);
> >>>> +#endif
> >>>> }
> >>>>
> >>>> extern struct pid_namespace *copy_pid_ns(int flags, struct pid_namespace *ns);
> >>>> @@ -34,12 +36,15 @@ extern void free_pid_ns(struct kref *kre
> >>>>
> >>>> static inline void put_pid_ns(struct pid_namespace *ns)
> >>>> {
> >>>> +#ifdef CONFIG_PID_NS
> >>>> kref_put(&ns->kref, free_pid_ns);
> >>>> +#endif
> >>>> }
> >>>>
> >>>> static inline struct task_struct *child_reaper(struct task_struct *tsk)
> >>>> {
> >>>> - return init_pid_ns.child_reaper;
> >>>> + BUG_ON(tsk != current);
> >>>> + return tsk->nsproxy->pid_ns->child_reaper;
> >>>> }
> >>>>
> >>>> #endif /* _LINUX_PID_NS_H */
> >>> This can't be bisect-safe, right? You can't just use
> >>> tsk->nsproxy->pid_ns, as you've pointed out yourself.
> >> I can :) See - I have a proving BUG_ON() here.
> >
> > I didn't know BUG_ON()'s actually warded off bugs :)
>
> It does not, but it says to code reader that this call
> expects something special. In this case - tsk is expected
> to be current always. And it is.

I don't think that's sufficient.

It's been awhile so I'm fuzzy on the details, but I think we only fixed
the race by always returning init_pid_ns instead of tsk->nsproxy_pid_ns,
and tsk being current is not safe.

> > You've tested this with the infamous NFS testcase?
>
> What testcase do you mean?

http://lkml.org/lkml/2007/1/17/65

> > I don't see *why* it would work for you, but if you claim it does, I
> > guess you'd know better than I :)
>
> I don't get you here. I've checked that the task passed to
> child_reaper is current always. This BUG_ON prevents later
> code from passing arbitrary task to it.

I don't think that's enough.

thanks,
-serge

Report message to a moderator

[Message index]

		[PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Thu, 24 May 2007 12:32
		[PATCH 1/13] Round up the API By: Pavel Emelianov on Thu, 24 May 2007 12:35
		Re: [PATCH 1/13] Round up the API By: serue on Thu, 24 May 2007 16:09
		Re: [PATCH 1/13] Round up the API By: ebiederm on Thu, 24 May 2007 16:22
		Re: [PATCH 1/13] Round up the API By: Pavel Emelianov on Thu, 24 May 2007 16:31
		Re: [PATCH 1/13] Round up the API By: serue on Thu, 24 May 2007 16:48
		Re: [PATCH 1/13] Round up the API By: Pavel Emelianov on Fri, 25 May 2007 07:00
		Re: [PATCH 1/13] Round up the API By: serue on Fri, 25 May 2007 13:02
		[PATCH 2/13] Small preparations for namespaces By: Pavel Emelianov on Thu, 24 May 2007 12:37
		Re: [PATCH 2/13] Small preparations for namespaces By: serue on Thu, 24 May 2007 16:08
		Re: [PATCH 2/13] Small preparations for namespaces By: Pavel Emelianov on Fri, 25 May 2007 06:58
		Re: [PATCH 2/13] Small preparations for namespaces By: serue on Fri, 25 May 2007 13:01
		Re: [PATCH 2/13] Small preparations for namespaces By: Pavel Emelianov on Fri, 25 May 2007 13:21
		Re: [PATCH 2/13] Small preparations for namespaces By: serue on Fri, 25 May 2007 13:55
		[PATCH 3/13] Introduciton of config option and clone flag By: Pavel Emelianov on Thu, 24 May 2007 12:42
		Re: [PATCH 3/13] Introduciton of config option and clone flag By: ebiederm on Thu, 24 May 2007 15:39
		[PATCH 4/13] Introduce the vpid fields and helpers for getting them By: Pavel Emelianov on Thu, 24 May 2007 12:44
		[PATCH 5/13] Expand the pid/task seeking functions set By: Pavel Emelianov on Thu, 24 May 2007 12:46
		Re: [PATCH 5/13] Expand the pid/task seeking functions set By: Dave Hansen on Thu, 24 May 2007 17:11
		Re: [PATCH 5/13] Expand the pid/task seeking functions set By: Pavel Emelianov on Fri, 25 May 2007 07:08
		Re: [PATCH 5/13] Expand the pid/task seeking functions set By: Sukadev Bhattiprolu on Fri, 25 May 2007 23:36
		[PATCH 6/13] Pid allocation/freeing procedures By: Pavel Emelianov on Thu, 24 May 2007 12:49
		[PATCH 7/13] Set virtual pids for a newly cloned task By: Pavel Emelianov on Thu, 24 May 2007 12:53
		[PATCH 8/13] The namespace cloning By: Pavel Emelianov on Thu, 24 May 2007 12:57
		[PATCH 9/13] Make proc be able to have multiple super blocks By: Pavel Emelianov on Thu, 24 May 2007 13:01
		[PATCH 10/13] Make proc draw pids from appropriate namespace By: Pavel Emelianov on Thu, 24 May 2007 13:04
		[PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Thu, 24 May 2007 13:06
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Thu, 24 May 2007 16:05
		Re: [PATCH 11/13] Changes to show virtual ids to user By: xemul on Thu, 24 May 2007 16:15
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Thu, 24 May 2007 16:33
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Fri, 25 May 2007 06:33
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Fri, 25 May 2007 15:48
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Cedric Le Goater on Tue, 29 May 2007 12:32
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Thu, 31 May 2007 07:57
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Thu, 31 May 2007 08:00
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Thu, 31 May 2007 11:26
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Thu, 31 May 2007 11:46
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Thu, 31 May 2007 13:41
		[PATCH 12/13] Show appropriate pids in proc By: Pavel Emelianov on Thu, 24 May 2007 13:08
		[PATCH 13/13] Make all proc entres accessible in a namespace By: Pavel Emelianov on Thu, 24 May 2007 13:13
		Instructions of how to make testing easy By: Pavel Emelianov on Thu, 24 May 2007 13:19
		Re: Instructions of how to make testing easy By: Pavel Emelianov on Thu, 24 May 2007 16:16
		Re: Instructions of how to make testing easy By: Cedric Le Goater on Thu, 24 May 2007 14:55
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Thu, 24 May 2007 15:09
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: xemul on Thu, 24 May 2007 16:11
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Thu, 24 May 2007 16:59
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Thu, 24 May 2007 18:56
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Thu, 24 May 2007 19:10
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 07:08
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Fri, 25 May 2007 13:25
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 13:53
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Fri, 25 May 2007 14:25
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Mon, 28 May 2007 07:48
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Tue, 29 May 2007 04:30
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Tue, 29 May 2007 07:47
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Tue, 29 May 2007 12:36
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 07:06
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Fri, 25 May 2007 14:55
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Thu, 24 May 2007 16:00
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Thu, 24 May 2007 16:20
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 06:29
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Fri, 25 May 2007 13:29
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Thu, 24 May 2007 16:26
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Thu, 24 May 2007 19:18
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 07:15
		Re: Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: dev on Mon, 28 May 2007 11:50
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Tue, 29 May 2007 13:07
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Daniel Lezcano on Thu, 24 May 2007 16:41
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 07:26
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Daniel Lezcano on Fri, 25 May 2007 08:30

Previous Topic:	Re: [ckrm-tech] [RFC] [PATCH 0/3] Add group fairness to CFS
Next Topic:	[RFC][PATCH 0/16] Enable cloning of pid namespace

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Oct 10 08:31:15 GMT 2025

Total time taken to generate the page: 0.14913 seconds