OpenVZ Forum: Devel » [PATCH 0/8] RSS controller based on process containers (v2)

Home » Mailing lists » Devel » [PATCH 0/8] RSS controller based on process containers (v2)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 8/8] Per-container pages reclamation [message #13280 is a reply to message #13147]

Thu, 24 May 2007 07:59

Balbir Singh
Messages: 491
Registered: August 2006

Senior Member

Pavel Emelianov wrote:
>> Index: linux-2.6.20/mm/rss_container.c
>> ============================================================ =======
>> --- linux-2.6.20.orig/mm/rss_container.c 2007-05-15 05:13:46.000000000 -0700
>> +++ linux-2.6.20/mm/rss_container.c 2007-05-16 20:45:45.000000000 -0700
>> @@ -212,6 +212,7 @@ void container_rss_del(struct page_conta
>>
>> css_put(&rss->css);
>> kfree(pc);
>> + init_page_container(page);
>
> This hunk is bad.
> See, when the page drops its mapcount to 0 it may be reused right
> after this if it belongs to a file map - another CPU can touch it.
> Thus you're risking to reset the wrong container.
>
> The main idea if the accounting is that you cannot trust the
> page_container(page) value after the page's mapcount became 0.
>

Good catch, I'll move the initialization to free_hot_cold_page().
I'm attaching a new patch. I've also gotten rid of the unused
variable page in container_rss_del().

I've compile and boot tested the fix

--
Thanks,
Balbir Singh
Linux Technology Center
IBM, ISTL

Report message to a moderator

[Message index]

		[PATCH 0/8] RSS controller based on process containers (v2) By: xemul on Mon, 09 April 2007 12:18
		[PATCH 1/8] Resource counters By: xemul on Mon, 09 April 2007 12:31
		[PATCH 2/8] Add container pointer on struct page By: xemul on Mon, 09 April 2007 12:37
		Re: [PATCH 2/8] Add container pointer on struct page By: xemul on Fri, 13 April 2007 14:48
		Re: [PATCH 2/8] Add container pointer on struct page By: Jean-Pierre Dion on Fri, 13 April 2007 13:56
		[PATCH 3/8] Add container pointer on mm_struct By: xemul on Mon, 09 April 2007 12:43
		[PATCH 4/8] RSS container core By: xemul on Mon, 09 April 2007 12:45
		[PATCH 5/8] RSS accounting hooks over the code By: xemul on Mon, 09 April 2007 12:50
		[PATCH 6/8] Per container OOM killer By: xemul on Mon, 09 April 2007 12:52
		[PATCH 7/8] Page scanner changes needed to implement per-container scanner By: xemul on Mon, 09 April 2007 12:57
		[PATCH 8/8] Per-container pages reclamation By: xemul on Mon, 09 April 2007 12:59
		Re: [PATCH 8/8] Per-container pages reclamation By: xemul on Tue, 24 April 2007 10:29
		Re: [PATCH 8/8] Per-container pages reclamation By: Balbir Singh on Tue, 24 April 2007 11:01
		Re: [PATCH 8/8] Per-container pages reclamation By: xemul on Tue, 24 April 2007 11:37
		Re: [PATCH 8/8] Per-container pages reclamation By: Balbir Singh on Tue, 24 April 2007 09:47
		Re: [PATCH 8/8] Per-container pages reclamation By: Balbir Singh on Wed, 02 May 2007 09:51
		Re: [PATCH 8/8] Per-container pages reclamation By: Balbir Singh on Thu, 17 May 2007 11:31
		Re: [PATCH 8/8] Per-container pages reclamation By: xemul on Mon, 21 May 2007 15:15
		Re: [PATCH 8/8] Per-container pages reclamation By: Balbir Singh on Thu, 24 May 2007 07:59
		Re: [PATCH 0/8] RSS controller based on process containers (v2) By: Peter Zijlstra on Mon, 09 April 2007 15:54
		Re: [PATCH 0/8] RSS controller based on process containers (v2) By: xemul on Tue, 10 April 2007 08:27
		Re: [PATCH 0/8] RSS controller based on process containers (v2) By: Vaidyanathan Srinivas on Thu, 19 April 2007 05:37

Previous Topic:	Re: [RFC] [PATCH 0/3] Add group fairness to CFS
Next Topic:	RSS controller v2 Test results (lmbench )

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Dec 02 01:20:22 GMT 2025

Total time taken to generate the page: 0.73414 seconds