OpenVZ Forum: Devel » [RFC][PATCH 1/5] Virtualization/containers: startup

Home » Mailing lists » Devel » [RFC][PATCH 1/5] Virtualization/containers: startup

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: Re: [RFC][PATCH 1/5] Virtualization/containers: startup [message #1295 is a reply to message #1289]

Mon, 06 February 2006 09:01

dev
Messages: 1693
Registered: September 2005
Location: Moscow

Senior Member

>>+static inline vps_t get_vps(vps_t vps)
>>+{
>>+ atomic_inc(&vps->refcnt);
>>+ return vps;
>>+}
>>+
>>+static inline void put_vps(vps_t vps)
>>+{
>>+ atomic_dec(&vps->refcnt);
>>+}
>
>
> I'm not too sure about the refcounting here .. you never destroy the
> object ? Also, why introduce your own refcounting mecanism instead of
> using existing ones ? You could probably use at least a kref to get a
> nice refcount + destructor instead of home made atomics based. Maybe
> some higher level structure if you think it makes sense (not too sure
> what this virtualization stuff is about so I can't comment on what data
> structure is appropriate here).
I replied to this in another email. Briefly:
this patch set doesn't introduce VPS/container creation/destroy
interface yet. Only small parts.
krefs are not needed here.

Kirill

Report message to a moderator

[Message index]

		[RFC][PATCH 1/5] Virtualization/containers: startup By: Kirill Korotaev on Fri, 03 February 2006 16:57
		[RFC][PATCH 2/5] Virtualization/containers: UIDs By: dev on Fri, 03 February 2006 17:01
		[RFC][PATCH 3/5] Virtualization/containers: UTSNAME By: dev on Fri, 03 February 2006 17:04
		Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME By: ebiederm on Mon, 06 February 2006 08:21
		Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME By: dev on Mon, 06 February 2006 08:51
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Fri, 03 February 2006 17:22
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Linus Torvalds on Fri, 03 February 2006 17:49
		Summary: PID virtualization , Containers, Migration By: Hubertus Franke on Fri, 03 February 2006 18:36
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Rik van Riel on Fri, 03 February 2006 18:36
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 14:52
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 08:39
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 08:58
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 09:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Dave Hansen on Mon, 06 February 2006 16:37
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 18:37
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 19:30
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Cedric Le Goater on Mon, 06 February 2006 22:40
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Tue, 07 February 2006 01:57
		swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Pavel Machek on Wed, 08 February 2006 21:54
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: ebiederm on Thu, 09 February 2006 18:20
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Kyle Moffett on Fri, 10 February 2006 00:21
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Sam Vilain on Fri, 10 February 2006 04:31
		Re: Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: vaverin on Fri, 10 February 2006 06:23
		Re: Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Sam Vilain on Sat, 11 February 2006 02:38
		Re: Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: vaverin on Sat, 11 February 2006 17:29
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Kyle Moffett on Fri, 10 February 2006 08:29
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Nigel Cunningham on Fri, 10 February 2006 05:40
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Dave Hansen on Fri, 03 February 2006 18:34
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Jeff Garzik on Fri, 03 February 2006 18:55
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Fri, 03 February 2006 19:18
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Fri, 03 February 2006 19:56
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Greg KH on Fri, 03 February 2006 20:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 15:10
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 15:05
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Dave Hansen on Mon, 06 February 2006 16:35
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 16:50
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Linus Torvalds on Mon, 06 February 2006 16:56
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 17:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Sam Vilain on Tue, 07 February 2006 00:28
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Tue, 07 February 2006 12:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Sam Vilain on Tue, 07 February 2006 22:21
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 20 February 2006 11:54
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Linus Torvalds on Fri, 03 February 2006 17:15
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Fri, 03 February 2006 20:34
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 15:11
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Sun, 05 February 2006 15:39
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 09:06
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Cedric Le Goater on Mon, 06 February 2006 22:31
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Tue, 07 February 2006 12:25
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Benjamin Herrenschmid on Mon, 06 February 2006 00:56
		Re: Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 09:01
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 08:31
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Fri, 10 February 2006 06:01

Previous Topic:	Versioning issue on vzquota-3.0.0-2
Next Topic:	Versioning issue on vzquota-3.0.0-2

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Oct 10 14:43:13 GMT 2025

Total time taken to generate the page: 0.15431 seconds