OpenVZ Forum: Devel » [PATCH] Consolidate udp hash calculations

Home » Mailing lists » Devel » [PATCH] Consolidate udp hash calculations

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] Consolidate udp hash calculations [message #12632 is a reply to message #12627]

Fri, 04 May 2007 19:39

davem
Messages: 463
Registered: February 2006

Senior Member

From: Pavel Emelianov <xemul@sw.ru>
Date: Fri, 04 May 2007 18:51:36 +0400

> Make access to udphash/udplitehash symmetrical to inet hashes.
>
> This may also help network namespaces, since they tend to use
> one hash for different namespaces by selecting the hash chain
> depending on a hash value and the namespace.
>
> Signed-off-by: Pavel Emelianov <xemul@openvz.org>

This is not the "UDP Hash Function", it is a mask to bring
the hash value modulo of the hash table size.

So your function name is misleading and makes the code
even worse.

I'm also not so sure this cleanup really adds any clarity,
even with a proper function name.

I can only assume you wish to do something with the UDP hash table
sizes, and therefore only want to have a need to touch one function.

Report message to a moderator

[Message index]

		[PATCH] Consolidate udp hash calculations By: xemul on Fri, 04 May 2007 14:47
		Re: [PATCH] Consolidate udp hash calculations By: davem on Fri, 04 May 2007 19:39
		Re: [PATCH] Consolidate udp hash calculations By: xemul on Mon, 07 May 2007 07:02
		Re: [PATCH] Consolidate udp hash calculations By: davem on Mon, 07 May 2007 07:04

Previous Topic:	[PATCH] Consolidate checking for tcp orphan count being too big
Next Topic:	[patch 049/455] Merge sys_clone()/sys_unshare() nsproxy and namespace handling

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Nov 05 20:44:14 GMT 2025

Total time taken to generate the page: 0.09885 seconds