OpenVZ Forum: Devel » [RFC][PATCH 1/5] Virtualization/containers: startup

Home » Mailing lists » Devel » [RFC][PATCH 1/5] Virtualization/containers: startup

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [RFC][PATCH 1/5] Virtualization/containers: startup [message #1258 is a reply to message #1251]

Fri, 03 February 2006 19:18

Hubertus Franke
Messages: 16
Registered: February 2006

Junior Member

Dave Hansen wrote:
> On Fri, 2006-02-03 at 09:49 -0800, Linus Torvalds wrote:
>
>>One thing I don't particularly like is some of the naming. To me "vps"
>>doesn't sound particularly generic or logical. I realize that it probably
>>makes perfect sense to you (and I assume it just means "virtual private
>>servers"), but especially if you see patches 1-3 to really be independent
>>of any "actual" virtualization code that is totally generic, I'd actually
>>prefer a less specialized name.
>
>
> I just did a global s/vps/container/ and it looks pretty reasonable, at
> least from my point of view.
>
> Couple of minor naming nitpick questions, though. Is vps/container_info
> really what we want to call it? It seems to me to be the basis for a
> real "container", without the _info part.
>
> "tsk->owner_container" That makes it sound like a pointer to the "task
> owner's container". How about "owning_container"? The "container
> owning this task". Or, maybe just "container"?
>
> Any particular reason for the "u32 id" in the vps_info struct as opposed
> to one of the more generic types? Do we want to abstract this one in
> the same way we do pid_t?
>
> The "host" in "host_container_info" doesn't mean much to me. Though, I
> guess it has some context in the UML space. Would "init_container_info"
> or "root_container_info" be more descriptive?
>
> Lastly, is this a place for krefs? I don't see a real need for a
> destructor yet, but the idea is fresh in my mind.
>
> How does the attached patch look?
>

Looks good to me ...

Similar to parts of our patch set, so overlap is good that means on
large parts we agree.
Let's go with Dave's adaption, since it already addresses some of
Linus's concerns and I start moving the pid isolation (in contrast to
pid virtualization) over this.

-- Hubertus

Report message to a moderator

[Message index]

		[RFC][PATCH 1/5] Virtualization/containers: startup By: Kirill Korotaev on Fri, 03 February 2006 16:57
		[RFC][PATCH 2/5] Virtualization/containers: UIDs By: dev on Fri, 03 February 2006 17:01
		[RFC][PATCH 3/5] Virtualization/containers: UTSNAME By: dev on Fri, 03 February 2006 17:04
		Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME By: ebiederm on Mon, 06 February 2006 08:21
		Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME By: dev on Mon, 06 February 2006 08:51
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Fri, 03 February 2006 17:22
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Linus Torvalds on Fri, 03 February 2006 17:49
		Summary: PID virtualization , Containers, Migration By: Hubertus Franke on Fri, 03 February 2006 18:36
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Rik van Riel on Fri, 03 February 2006 18:36
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 14:52
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 08:39
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 08:58
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 09:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Dave Hansen on Mon, 06 February 2006 16:37
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 18:37
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 19:30
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Cedric Le Goater on Mon, 06 February 2006 22:40
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Tue, 07 February 2006 01:57
		swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Pavel Machek on Wed, 08 February 2006 21:54
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: ebiederm on Thu, 09 February 2006 18:20
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Kyle Moffett on Fri, 10 February 2006 00:21
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Sam Vilain on Fri, 10 February 2006 04:31
		Re: Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: vaverin on Fri, 10 February 2006 06:23
		Re: Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Sam Vilain on Sat, 11 February 2006 02:38
		Re: Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: vaverin on Sat, 11 February 2006 17:29
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Kyle Moffett on Fri, 10 February 2006 08:29
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Nigel Cunningham on Fri, 10 February 2006 05:40
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Dave Hansen on Fri, 03 February 2006 18:34
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Jeff Garzik on Fri, 03 February 2006 18:55
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Fri, 03 February 2006 19:18
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Fri, 03 February 2006 19:56
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Greg KH on Fri, 03 February 2006 20:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 15:10
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 15:05
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Dave Hansen on Mon, 06 February 2006 16:35
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 16:50
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Linus Torvalds on Mon, 06 February 2006 16:56
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 17:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Sam Vilain on Tue, 07 February 2006 00:28
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Tue, 07 February 2006 12:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Sam Vilain on Tue, 07 February 2006 22:21
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 20 February 2006 11:54
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Linus Torvalds on Fri, 03 February 2006 17:15
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Fri, 03 February 2006 20:34
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 15:11
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Sun, 05 February 2006 15:39
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 09:06
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Cedric Le Goater on Mon, 06 February 2006 22:31
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Tue, 07 February 2006 12:25
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Benjamin Herrenschmid on Mon, 06 February 2006 00:56
		Re: Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 09:01
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 08:31
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Fri, 10 February 2006 06:01

Previous Topic:	Versioning issue on vzquota-3.0.0-2
Next Topic:	Versioning issue on vzquota-3.0.0-2

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Oct 10 16:41:28 GMT 2025

Total time taken to generate the page: 0.20239 seconds