OpenVZ Forum: Devel » [PATCH] cfq: get rid of cfqq hash

Home » Mailing lists » Devel » [PATCH] cfq: get rid of cfqq hash

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] cfq: get rid of cfqq hash [message #12310 is a reply to message #12308]

Tue, 24 April 2007 18:29

Jens Axboe
Messages: 30
Registered: October 2006

Member

On Tue, Apr 24 2007, Jens Axboe wrote:
> - if (key != CFQ_KEY_ASYNC)
> + if (!is_sync)
> cfq_mark_cfqq_idle_window(cfqq);
> + else
> + cfq_mark_cfqq_sync(cfqq);

Woops, should be

if (is_sync) {
cfq_mark_cfqq_idle_window(cfqq);
cfq_mark_cfqq_sync(cfqq);
}

of course.

> +static struct cfq_io_context *
> +cfq_get_io_context_noalloc(struct cfq_data *cfqd, struct task_struct *tsk)
> +{
> + struct cfq_io_context *cic = NULL;
> + struct io_context *ioc;
> +
> + ioc = tsk->io_context;
> + if (ioc)
> + cic = cfq_cic_rb_lookup(cfqd, ioc);
> +
> + return cic;
> +}

I'll change that to just call cfq_cic_rb_lookup(), returning NULL for
NULL ioc.

--
Jens Axboe

Report message to a moderator

[Message index]

		[PATCH] cfq: get rid of cfqq hash By: Vasily Tarasov on Tue, 24 April 2007 11:53
		Re: [PATCH] cfq: get rid of cfqq hash By: Vasily Tarasov on Tue, 24 April 2007 12:51
		Re: [PATCH] cfq: get rid of cfqq hash By: Jens Axboe on Tue, 24 April 2007 12:27
		Re: [PATCH] cfq: get rid of cfqq hash By: Jens Axboe on Tue, 24 April 2007 17:22
		Re: [PATCH] cfq: get rid of cfqq hash By: Jens Axboe on Tue, 24 April 2007 18:29
		Re: [PATCH] cfq: get rid of cfqq hash By: Jens Axboe on Tue, 24 April 2007 18:33
		Re: [PATCH] cfq: get rid of cfqq hash By: Vasily Tarasov on Wed, 25 April 2007 07:32

Previous Topic:	[PATCH 0/7] Containers (V8): Generic Process Containers
Next Topic:	[patch 0/8] mount ownership and unprivileged mount syscall (v4)

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Dec 13 05:48:56 GMT 2025

Total time taken to generate the page: 0.20899 seconds