OpenVZ Forum: Devel » [NETLINK] Don't attach callback to a going-away netlink socket

Home » Mailing lists » Devel » [NETLINK] Don't attach callback to a going-away netlink socket

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [NETLINK] Don't attach callback to a going-away netlink socket [message #12148 is a reply to message #12143]

Wed, 18 April 2007 08:44

Evgeniy Polyakov
Messages: 11
Registered: November 2006

Junior Member

On Wed, Apr 18, 2007 at 12:32:40PM +0400, Pavel Emelianov (xemul@sw.ru) wrote:
> Evgeniy Polyakov wrote:
> > On Wed, Apr 18, 2007 at 12:16:18PM +0400, Pavel Emelianov (xemul@sw.ru) wrote:
> >> Sorry, I forgot to put netdev and David in Cc when I first sent it.
> >>
> >> There is a race between netlink_dump_start() and netlink_release()
> >> that can lead to the situation when a netlink socket with non-zero
> >> callback is freed.
> >
> > Out of curiosity, why not to fix a netlink_dump_start() to remove
> > callback in error path, since in 'no-error' path it removes it in
>
> Error path is not relevant here. The problem is that we
> keep a calback on a socket that is about to be freed.

Yes, you are right, that it will not be freed in netlink_release(),
but it will be freed in netlink_dump() after it is processed (in no-error
path only though).

--
Evgeniy Polyakov

Report message to a moderator

[Message index]

		[NETLINK] Don't attach callback to a going-away netlink socket By: xemul on Wed, 18 April 2007 08:12
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 08:17
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Patrick McHardy on Wed, 18 April 2007 08:26
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 08:42
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Patrick McHardy on Wed, 18 April 2007 08:50
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 09:07
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Patrick McHardy on Wed, 18 April 2007 09:16
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 09:29
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: xemul on Wed, 18 April 2007 08:27
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 08:44
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: xemul on Wed, 18 April 2007 08:59
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 09:14
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: davem on Thu, 19 April 2007 00:06
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Herbert Xu on Thu, 19 April 2007 02:13
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: davem on Sun, 29 April 2007 06:18
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Herbert Xu on Wed, 02 May 2007 04:12
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: davem on Thu, 03 May 2007 10:17

Previous Topic:	[PATCH] Invalid return value of execve() resulting in oopses
Next Topic:	[PATCH] Rework dev_base via list_head (v2)

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Aug 26 23:04:54 GMT 2025

Total time taken to generate the page: 0.11276 seconds