OpenVZ Forum: Devel » [PATCH] paride drivers: initialize spinlocks

Home » Mailing lists » Devel » [PATCH] paride drivers: initialize spinlocks

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH] paride drivers: initialize spinlocks [message #12035]

Mon, 16 April 2007 10:05

Alexey Dobriyan
Messages: 195
Registered: August 2006

Senior Member

pcd_lock and pf_spin_lock are passed to blk_init_queue() which,
seeing them as valid lock pointer, sets it as ->queue_lock.

The problem is that pcd_lock and pf_spin_lock aren't initialized
anywhere.

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---

drivers/block/paride/pcd.c | 2 +-
drivers/block/paride/pf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/block/paride/pcd.c
+++ b/drivers/block/paride/pcd.c
@@ -140,7 +140,7 @@ #include <linux/spinlock.h>
#include <linux/blkdev.h>
#include <asm/uaccess.h>

-static spinlock_t pcd_lock;
+static DEFINE_SPINLOCK(pcd_lock);

module_param(verbose, bool, 0644);
module_param(major, int, 0);
--- a/drivers/block/paride/pf.c
+++ b/drivers/block/paride/pf.c
@@ -154,7 +154,7 @@ #include <linux/blkdev.h>
#include <linux/blkpg.h>
#include <asm/uaccess.h>

-static spinlock_t pf_spin_lock;
+static DEFINE_SPINLOCK(pf_spin_lock);

module_param(verbose, bool, 0644);
module_param(major, int, 0);

Report message to a moderator