OpenVZ Forum: Devel » dead code: EXT3_IOC_WAIT_FOR

Home » Mailing lists » Devel » dead code: EXT3_IOC_WAIT_FOR_READONLY?

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

dead code: EXT3_IOC_WAIT_FOR_READONLY? [message #11261]

Fri, 16 March 2007 11:16

vaverin
Messages: 708
Registered: September 2005

Senior Member

Hi all,

I've found some strange ext3 ioctl under CONFIG_JBD_DEBUG:
EXT3_IOC_WAIT_FOR_READONLY.

I had DEBUG_SPINLOCK enabled and my kernel was crashed on wait-for-readonly.c
test from ext3-tools because ioctl handler tries to use uninitialized
EXT3_SB(sb)->ro_wait_queue and waits EXT3_SB(sb)->turn_ro_timer that nobody uses
in kernel.

I do not understand the function of this ioctl and believe this code is dead
long time ago. From my POV it makes sense to remove it from kernel instead of
fixing it. Has somebody any objections?

Thank you,
Vasily Averin

Report message to a moderator

[Message index]

		dead code: EXT3_IOC_WAIT_FOR_READONLY? By: vaverin on Fri, 16 March 2007 11:16
		Re: dead code: EXT3_IOC_WAIT_FOR_READONLY? By: Andrew Morton on Fri, 16 March 2007 12:03

Previous Topic:	Re: [RFC] kernel/pid.c pid allocation wierdness
Next Topic:	Re: [RFC] kernel/pid.c pid allocation wierdness

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Oct 16 17:08:40 GMT 2025

Total time taken to generate the page: 0.45367 seconds