| Re: [ckrm-tech] [PATCH 3/3][RFC] Containers: Pagecache controller reclaim [message #10922] |
Wed, 07 March 2007 11:58 |
Vaidyanathan Srinivas
Messages: 49
Registered: February 2007
|
Member |
|
|
Shane wrote:
> On Tue, 2007-03-06 at 16:43 +0530, Vaidyanathan Srinivasan wrote:
>> Please let me know if so see any problem running the patch. The
>> patches are against 2.6.20 only since dependent patches are at that level.
>
> My problem - a bad copy of the patch. It patches o.k.
> However, it fails to compile vmscan. This looks a bit dodgy;
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ++++++++++++
>
> @@ -1470,11 +1494,13 @@ unsigned long shrink_all_memory(unsigned
> int pass;
> struct reclaim_state reclaim_state;
> struct scan_control sc = {
> - .gfp_mask = GFP_KERNEL,
> + .gfp_mask = GFdefined(CONFIG_CONTAINER_PAGECACHE_ACCT)
> +P_KERNEL,
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ++++++++++++
>
> I deleted what looks like an over-enthusiastic "copy-and-paste", and it
> compiled o.k.
> Testing continues.
OOPS!! How did it get there! That is certainly some random mouse
click. Thanks for pointing that out.
--Vaidy
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
