OpenVZ Forum: Devel » [RFC][PATCH 0/7] Resource controllers based on process containers

Home » Mailing lists » Devel » [RFC][PATCH 0/7] Resource controllers based on process containers

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [RFC][PATCH 6/7] Account for the number of tasks within container [message #10906 is a reply to message #10894]

Wed, 07 March 2007 02:00

Paul Menage
Messages: 642
Registered: September 2006

Senior Member

Hi Pavel,

On 3/6/07, Pavel Emelianov <xemul@sw.ru> wrote:
> diff -upr linux-2.6.20.orig/include/linux/sched.h linux-2.6.20-0/include/linux/sched.h
> --- linux-2.6.20.orig/include/linux/sched.h 2007-03-06 13:33:28.000000000 +0300
> +++ linux-2.6.20-0/include/linux/sched.h 2007-03-06 13:33:28.000000000 +0300
> @@ -1052,6 +1055,9 @@ struct task_struct {
> #ifdef CONFIG_FAULT_INJECTION
> int make_it_fail;
> #endif
> +#ifdef CONFIG_PROCESS_CONTAINER
> + struct numproc_container *numproc_cnt;
> +#endif
> };

Why do you need a pointer added to task_struct? One of the main points
of the generic containers is to avoid every different subsystem and
resource controller having to add new pointers there.

> +
> + rcu_read_lock();
> + np = numproc_from_cont(task_container(current, &numproc_subsys));
> + css_get_current(&np->css);

There's no need to hold a reference here - by definition, the task's
container can't go away while the task is in it.

Also, shouldn't you have an attach() method to move the count from one
container to another when a task moves?

Paul

Report message to a moderator

[Message index]

		[RFC][PATCH 0/7] Resource controllers based on process containers By: xemul on Tue, 06 March 2007 14:42
		[RFC][PATCH 1/7] Resource counters By: xemul on Tue, 06 March 2007 14:47
		Re: [RFC][PATCH 1/7] Resource counters By: Balbir Singh on Wed, 07 March 2007 04:03
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Wed, 07 March 2007 07:17
		Re: [RFC][PATCH 1/7] Resource counters By: Herbert Poetzl on Fri, 09 March 2007 16:37
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Sun, 11 March 2007 09:01
		Re: [RFC][PATCH 1/7] Resource counters By: ebiederm on Sun, 11 March 2007 19:00
		Re: [RFC][PATCH 1/7] Resource counters By: Herbert Poetzl on Mon, 12 March 2007 01:16
		Re: [RFC][PATCH 1/7] Resource counters By: ebiederm on Tue, 13 March 2007 09:09
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Tue, 13 March 2007 09:27
		Re: [RFC][PATCH 1/7] Resource counters By: Herbert Poetzl on Tue, 13 March 2007 15:21
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Tue, 13 March 2007 15:41
		Re: [RFC][PATCH 1/7] Resource counters By: Srivatsa Vaddagiri on Tue, 13 March 2007 16:07
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Wed, 14 March 2007 07:12
		Re: [RFC][PATCH 1/7] Resource counters By: ebiederm on Thu, 15 March 2007 16:51
		Re: Re: [RFC][PATCH 1/7] Resource counters By: dev on Tue, 13 March 2007 09:36
		Re: [RFC][PATCH 1/7] Resource counters By: Herbert Poetzl on Tue, 13 March 2007 16:32
		[RFC][PATCH 2/7] RSS controller core By: xemul on Tue, 06 March 2007 14:53
		Re: [RFC][PATCH 2/7] RSS controller core By: Andrew Morton on Tue, 06 March 2007 22:00
		Re: [RFC][PATCH 2/7] RSS controller core By: dev on Sun, 11 March 2007 12:13
		Re: [RFC][PATCH 2/7] RSS controller core By: Andrew Morton on Sun, 11 March 2007 12:51
		Re: [RFC][PATCH 2/7] RSS controller core By: Balbir Singh on Sun, 11 March 2007 15:51
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Sun, 11 March 2007 19:34
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 01:00
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Mon, 12 March 2007 18:42
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 22:41
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Mon, 12 March 2007 09:02
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 21:11
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Tue, 13 March 2007 07:17
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Tue, 13 March 2007 15:05
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Tue, 13 March 2007 15:32
		Re: [RFC][PATCH 2/7] RSS controller core By: dev on Tue, 13 March 2007 15:10
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: Kirill Korotaev on Mon, 12 March 2007 09:10
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Tue, 13 March 2007 09:26
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: dev on Tue, 13 March 2007 15:30
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: dev on Tue, 13 March 2007 10:06
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: Andrew Morton on Tue, 13 March 2007 10:49
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Tue, 13 March 2007 14:59
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Tue, 13 March 2007 17:05
		Re: [RFC][PATCH 2/7] RSS controller core By: mel on Wed, 14 March 2007 15:38
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: Paul Menage on Sun, 18 March 2007 22:44
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Mon, 19 March 2007 17:41
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Fri, 09 March 2007 16:48
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Sun, 11 March 2007 09:08
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Sun, 11 March 2007 14:32
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Sun, 11 March 2007 15:04
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 00:41
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Mon, 12 March 2007 08:31
		Re: [RFC][PATCH 2/7] RSS controller core By: Balbir Singh on Mon, 12 March 2007 09:55
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 23:43
		Re: [RFC][PATCH 2/7] RSS controller core By: Balbir Singh on Tue, 13 March 2007 01:57
		Re: [RFC][PATCH 2/7] RSS controller core By: Srivatsa Vaddagiri on Tue, 13 March 2007 02:24
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Tue, 13 March 2007 16:06
		Re: [RFC][PATCH 2/7] RSS controller core By: Balbir Singh on Wed, 07 March 2007 05:37
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Wed, 07 March 2007 07:25
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Mon, 12 March 2007 23:02
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Sun, 18 March 2007 16:58
		Re: [RFC][PATCH 2/7] RSS controller core By: akpm on Tue, 13 March 2007 06:04
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Tue, 13 March 2007 17:26
		Re: [RFC][PATCH 2/7] RSS controller core By: Alan Cox on Tue, 13 March 2007 19:09
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Fri, 16 March 2007 00:55
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Fri, 16 March 2007 16:31
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Fri, 16 March 2007 18:54
		Re: [RFC][PATCH 2/7] RSS controller core By: mel on Wed, 14 March 2007 16:47
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Tue, 13 March 2007 20:28
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Tue, 13 March 2007 15:11
		Re: [RFC][PATCH 2/7] RSS controller core By: dev on Tue, 13 March 2007 15:54
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Wed, 14 March 2007 20:42
		Re: [RFC][PATCH 2/7] RSS controller core By: mel on Tue, 20 March 2007 18:57
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Fri, 16 March 2007 19:46
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Sun, 18 March 2007 17:42
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 19 March 2007 15:48
		controlling mmap()'d vs read/write() pages By: Dave Hansen on Tue, 20 March 2007 16:15
		Re: controlling mmap()'d vs read/write() pages By: ebiederm on Tue, 20 March 2007 21:19
		Re: controlling mmap()'d vs read/write() pages By: Herbert Poetzl on Fri, 23 March 2007 00:51
		Re: controlling mmap()'d vs read/write() pages By: Nick Piggin on Fri, 23 March 2007 05:57
		Re: controlling mmap()'d vs read/write() pages By: ebiederm on Fri, 23 March 2007 10:12
		Re: controlling mmap()'d vs read/write() pages By: Dave Hansen on Fri, 23 March 2007 16:41
		Re: controlling mmap()'d vs read/write() pages By: Herbert Poetzl on Fri, 23 March 2007 18:16
		Re: controlling mmap()'d vs read/write() pages By: Balbir Singh on Wed, 28 March 2007 09:18
		Re: controlling mmap()'d vs read/write() pages By: Nick Piggin on Fri, 23 March 2007 10:47
		Re: controlling mmap()'d vs read/write() pages By: ebiederm on Fri, 23 March 2007 12:21
		Re: controlling mmap()'d vs read/write() pages By: Nick Piggin on Wed, 28 March 2007 07:33
		[RFC][PATCH 3/7] Data structures changes for RSS accounting By: xemul on Tue, 06 March 2007 14:55
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: ebiederm on Sun, 11 March 2007 19:13
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: dev on Mon, 12 March 2007 16:16
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: Dave Hansen on Mon, 12 March 2007 16:48
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: xemul on Mon, 12 March 2007 17:19
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: Balbir Singh on Mon, 12 March 2007 17:21
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: Dave Hansen on Mon, 12 March 2007 17:27
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: xemul on Tue, 13 March 2007 07:10
		[RFC][PATCH 4/7] RSS accounting hooks over the code By: xemul on Tue, 06 March 2007 14:57
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: xemul on Wed, 14 March 2007 15:43
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Cedric Le Goater on Wed, 14 March 2007 15:37
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: ebiederm on Sun, 11 March 2007 19:14
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: dev on Mon, 12 March 2007 16:23
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Dave Hansen on Mon, 12 March 2007 16:50
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: dev on Mon, 12 March 2007 17:07
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Herbert Poetzl on Mon, 12 March 2007 23:54
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: ebiederm on Tue, 13 March 2007 09:58
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Tue, 13 March 2007 10:25
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Ethan Solomita on Wed, 28 March 2007 20:15
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Dave Hansen on Mon, 12 March 2007 17:33
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: ebiederm on Tue, 13 March 2007 09:43
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: ebiederm on Tue, 13 March 2007 16:01
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Wed, 14 March 2007 03:51
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Balbir Singh on Wed, 14 March 2007 06:42
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Wed, 14 March 2007 06:57
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Balbir Singh on Wed, 14 March 2007 07:48
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Vaidyanathan Srinivas on Wed, 14 March 2007 13:25
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Wed, 14 March 2007 13:49
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: dev on Wed, 14 March 2007 16:16
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Thu, 15 March 2007 05:01
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Vaidyanathan Srinivas on Wed, 14 March 2007 14:43
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Balbir Singh on Thu, 15 March 2007 05:44
		[RFC][PATCH 5/7] Per-container OOM killer and page reclamation By: xemul on Tue, 06 March 2007 15:01
		Re: [RFC][PATCH 5/7] Per-container OOM killer and page reclamation By: Balbir Singh on Fri, 09 March 2007 21:21
		Re: [RFC][PATCH 5/7] Per-container OOM killer and page reclamation By: xemul on Sun, 11 March 2007 08:39
		[RFC][PATCH 6/7] Account for the number of tasks within container By: xemul on Tue, 06 March 2007 15:02
		Re: [RFC][PATCH 6/7] Account for the number of tasks within container By: Paul Menage on Wed, 07 March 2007 02:00
		Re: [RFC][PATCH 6/7] Account for the number of tasks within container By: xemul on Wed, 07 March 2007 07:10
		Re: [RFC][PATCH 6/7] Account for the number of tasks within container By: Paul Menage on Thu, 08 March 2007 13:49
		Re: [RFC][PATCH 6/7] Account for the number of tasks within container By: xemul on Sun, 11 March 2007 08:34
		[RFC][PATCH 7/7] Account for the number of files opened within container By: xemul on Tue, 06 March 2007 15:05
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: Paul Menage on Wed, 07 March 2007 02:02
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: xemul on Wed, 07 March 2007 07:27
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: Balbir Singh on Wed, 07 March 2007 06:52
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: xemul on Wed, 07 March 2007 07:30
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: dev on Wed, 07 March 2007 09:30

Previous Topic:	Re: [ckrm-tech] [PATCH 7/7] containers (V7): Container interface to nsproxy subsystem
Next Topic:	Linux-VServer example results for sharing vs. separate mappings ...

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Aug 07 20:29:48 GMT 2024

Total time taken to generate the page: 0.02946 seconds