Re: [PATCH 3/4] namespace containers: add nsproxy to nscont struct [message #10498] |
Mon, 19 February 2007 22:31 |
Paul Menage
Messages: 642 Registered: September 2006
|
Senior Member |
|
|
On 2/19/07, Serge E. Hallyn <serue@us.ibm.com> wrote:
> From: Serge E. Hallyn <serue@us.ibm.com>
> Subject: [PATCH 3/4] namespace containers: add nsproxy to nscont struct
>
> Each ns container is associated with an nsproxy. Add that
> nsproxy to the nscont struct, set it when a container is auto-
> created on clone/unshare, and inc/dec the nsproxy to account for
> each container referencing it.
>
> Note that once the nscont->nsproxy is set, it will never change
> for the duration of the container's lifetime.
>
> Changelog:
> Feb 14: added ss->init_from_task() hook so ns_container
> can initialize a container's private data from a task
> on clone().
>
Useful feature, but I think it would be simpler to just add an extra
parameter to ss->create(), to indicate the parent process that's
cloning, or NULL if it's being created by hand. I'll add that to the
next patchset.
Paul
|
|
|