OpenVZ Forum - RDF feed
type: channel
items: Re: [RFC][v2][patch 0/12][CFQ-cgroup]Yet another I/O bandwidth controlling subsystem for CGroups bas

Re: [RFC][v2][patch 0/12][CFQ-cgroup]Yet another I/O bandwidth controlling subsystem for CGroups bas
type: item
description: Satoshi UCHIDA wrote: > Hi, Andrea. > > Thanks for bug reports. > I fix this problem. > > This problem causes by miss of trace for children groups. > Please adopt and test this patch. OK, I can confirm the fix resolves the problem. Tested-by: Andrea Righi <righi.andrea@gmail.com> > > If OK, this amendment is adopted when I release new patch-set. > > > Regards, > Satoshi Uchida. > > > diff --git a/block/cfq-cgroup.c b/block/cfq-cgroup.c > index f868f4f..64561f5 100644 > --- a/block/cfq-cgroup.c > +++ b/block/cfq-cgroup.c > @@ -183,7 +184,7 @@ static void *cfq_cgroup_init_cfq_data(struct cfq_cgroup *cfqc, struct cfq_data * > > /* check and create cfq_data for children */ > if (cfqc->css.cgroup) > - list_for_each_entry(child, &cfqc->css.cgroup->children, children){ > + list_for_each_entry(child, &cfqc->css.cgroup->children, sibling){ > cfq_cgroup_init_cfq_data(cgroup_to_cfq_cgroup(child), cfqd); > } > > >> -----Original Message----- >> From: Andrea Righi [mailto:righi.andrea@gmail.com] >> Sent: Friday, May 30, 2008 7:37 PM >> To: Satoshi UCHIDA >> Cc: 'Ryo Tsuruta'; axboe@kernel.dk; vtaras@openvz.org; >> containers@lists.linux-foundation.org; tom-sugawara@ap.jp.nec.com; >> linux-kernel@vger.kernel.org >> Subject: Re: [RFC][v2][patch 0/12][CFQ-cgroup]Yet another I/O bandwidth >> controlling subsystem for CGroups based on CFQ >> >> Satoshi UCHIDA wrote: >>> Hi, Tsuruta-san. >>> >>>> I'm looking forward to your report. >> Hi Satoshi, >> >> I'm testing your patch agains latest Linus git and I've got the >> following bug. It can be easily reproduced creating a cgroup, switching >> the i/o scheduler from cfq to any other and switch back to cfq again. >> >> -Andrea >> >> BUG: unable to handle kernel paging request at ffffffeb >> IP: [<c0212dc6>] cfq_cgroup_sibling_tree_add+0x36/0x90 >> Oops: 0000 [#1] SMP >> Modules linked in: i2c_piix4 ne2k_pci 8390 i2c_core >> >> Pid: 3543, comm: bash Not tainted (2.6.26-rc4 #1) >> EIP: 0060:[<c0212dc6>] EFLAGS: 00010286 CPU: 0 >> EIP is at…
creator: Andrea Righi
date: 2008-06-22T17:04:33-00:00