[GIT PATCH] actually check va randomization
Rather than just documenting this in the readme, actually spit out a warning on it. You can pull from: git://git.sr71.net/~dave/cryo-forhallyn.git/ -- Dave _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [GIT PATCH] actually check va randomization
Quoting Dave Hansen (dave@linux.vnet.ibm.com): > Rather than just documenting this in the readme, actually spit > out a warning on it. > > You can pull from: git://git.sr71.net/~dave/cryo-forhallyn.git/ > > -- Dave Thanks, merged. -serge _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
Dave Hansen [dave@linux.vnet.ibm.com] wrote: | Rather than just documenting this in the readme, actually spit | out a warning on it. Why not just bail out ? Its mostly unreliable at that point anyway. Besides, the warning can get buried in lot of other output. --- >From 84d005031a8a17bdca62dc541c296a3bea74658c Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> Date: Wed, 11 Jun 2008 11:22:17 -0700 Subject: [PATCH] cryo currently requires randomize_va_space to be 0. Fail if it is not. --- cr.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cr.c b/cr.c index db3ada0..217c5e7 100644 --- a/cr.c +++ b/cr.c @@ -1464,6 +1464,7 @@ void check_for_va_randomize(void) return; fprintf(stderr, "WARNING: %s is set to: %d\n", VA_RANDOM_FILE, enabled); fprintf(stderr, " Please set to 0 to make cryo more reliable\n"); + exit(1); } void usage(void) -- 1.5.2.5 _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
Quoting sukadev@us.ibm.com (sukadev@us.ibm.com): > Dave Hansen [dave@linux.vnet.ibm.com] wrote: > | Rather than just documenting this in the readme, actually spit > | out a warning on it. > > Why not just bail out ? Its mostly unreliable at that point anyway. > Besides, the warning can get buried in lot of other output. > --- > >From 84d005031a8a17bdca62dc541c296a3bea74658c Mon Sep 17 00:00:00 2001 > From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> > Date: Wed, 11 Jun 2008 11:22:17 -0700 > Subject: [PATCH] cryo currently requires randomize_va_space to be 0. Fail if it is not. > > --- > cr.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/cr.c b/cr.c > index db3ada0..217c5e7 100644 > --- a/cr.c > +++ b/cr.c > @@ -1464,6 +1464,7 @@ void check_for_va_randomize(void) > return; > fprintf(stderr, "WARNING: %s is set to: %d\n", VA_RANDOM_FILE, enabled); > fprintf(stderr, " Please set to 0 to make cryo more reliable\n"); > + exit(1); > } > > void usage(void) Oh... Thanks, Suka, I'd just done the same thing using an ERROR(). thanks, -serge _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers