[PATCH]: Propagate error code from devpts_pty_new
From: Sukadev Bhattiprolu <sukadev@us.ibm.com> Subject: [PATCH]: Propagate error code from devpts_pty_new Have ptmx_open() propagate any error code returned by devpts_pty_new() (which returns either 0 or -ENOMEM anyway). Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com> --- drivers/char/tty_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: 2.6.25-rc8-mm2/drivers/char/tty_io.c =================================================================== --- 2.6.25-rc8-mm2.orig/drivers/char/tty_io.c 2008-04-16 09:38:23.000000000 -0700 +++ 2.6.25-rc8-mm2/drivers/char/tty_io.c 2008-04-16 09:51:11.000000000 -0700 @@ -2835,8 +2835,8 @@ static int ptmx_open(struct inode *inode filp->private_data = tty; file_move(filp, &tty->tty_files); - retval = -ENOMEM; - if (devpts_pty_new(tty->link)) + retval = devpts_pty_new(tty->link); + if (retval) goto out1; check_tty_count(tty, "tty_open"); _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [PATCH]: Propagate error code from devpts_pty_new
Quoting sukadev@us.ibm.com (sukadev@us.ibm.com): > From: Sukadev Bhattiprolu <sukadev@us.ibm.com> > Subject: [PATCH]: Propagate error code from devpts_pty_new > > Have ptmx_open() propagate any error code returned by devpts_pty_new() > (which returns either 0 or -ENOMEM anyway). > > Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com> Seems nice and non-contentuous. Acked-by: Serge Hallyn <serue@us.ibm.com> thanks, -serge > --- > drivers/char/tty_io.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: 2.6.25-rc8-mm2/drivers/char/tty_io.c > =================================================================== > --- 2.6.25-rc8-mm2.orig/drivers/char/tty_io.c 2008-04-16 09:38:23.000000000 -0700 > +++ 2.6.25-rc8-mm2/drivers/char/tty_io.c 2008-04-16 09:51:11.000000000 -0700 > @@ -2835,8 +2835,8 @@ static int ptmx_open(struct inode *inode > filp->private_data = tty; > file_move(filp, &tty->tty_files); > > - retval = -ENOMEM; > - if (devpts_pty_new(tty->link)) > + retval = devpts_pty_new(tty->link); > + if (retval) > goto out1; > > check_tty_count(tty, "tty_open"); _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
Serge E. Hallyn wrote: > Quoting sukadev@us.ibm.com (sukadev@us.ibm.com): >> From: Sukadev Bhattiprolu <sukadev@us.ibm.com> >> Subject: [PATCH]: Propagate error code from devpts_pty_new >> >> Have ptmx_open() propagate any error code returned by devpts_pty_new() >> (which returns either 0 or -ENOMEM anyway). >> >> Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com> > > Seems nice and non-contentuous. > > Acked-by: Serge Hallyn <serue@us.ibm.com> Acked-by: H. Peter Anvin <hpa@zytor.com> _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers