OpenVZ Forum - RDF feed
type: channel
items: [PATCH][IPVS] Relax the module get/put in ip_vs_app.c
items: Re: [PATCH][IPVS] Relax the module get/put in ip_vs_app.c

[PATCH][IPVS] Relax the module get/put in ip_vs_app.c
type: item
description: Both try_module_get/module_put already handle the module == NULL case, so no need in manual checking. This patch fits both net-2.6 and net-2.6.25. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- diff --git a/net/ipv4/ipvs/ip_vs_app.c b/net/ipv4/ipvs/ip_vs_app.c index 664cb8e..535abe0 100644 --- a/net/ipv4/ipvs/ip_vs_app.c +++ b/net/ipv4/ipvs/ip_vs_app.c @@ -51,18 +51,13 @@ static DEFINE_MUTEX(__ip_vs_app_mutex); */ static inline int ip_vs_app_get(struct ip_vs_app *app) { - /* test and get the module atomically */ - if (app->module) - return try_module_get(app->module); - else - return 1; + return try_module_get(app->module); } static inline void ip_vs_app_put(struct ip_vs_app *app) { - if (app->module) - module_put(app->module); + module_put(app->module); }
creator: Pavel Emelianov
date: 2007-11-19T09:58:14-00:00

Re: [PATCH][IPVS] Relax the module get/put in ip_vs_app.c
type: item
description: On Mon, Nov 19, 2007 at 12:58:14PM +0300, Pavel Emelyanov wrote: > Both try_module_get/module_put already handle the module == NULL > case, so no need in manual checking. > > This patch fits both net-2.6 and net-2.6.25. > > Signed-off-by: Pavel Emelyanov <xemul@openvz.org> Thanks, that looks fine to me. Acked-by: Simon Horman <horms@verge.net.au>
creator: Simon Horman
date: 2007-11-20T02:28:18-00:00

Re: [PATCH][IPVS] Relax the module get/put in ip_vs_app.c
type: item
description: From: Simon Horman <horms@verge.net.au> Date: Tue, 20 Nov 2007 11:28:18 +0900 > On Mon, Nov 19, 2007 at 12:58:14PM +0300, Pavel Emelyanov wrote: > > Both try_module_get/module_put already handle the module == NULL > > case, so no need in manual checking. > > > > This patch fits both net-2.6 and net-2.6.25. > > > > Signed-off-by: Pavel Emelyanov <xemul@openvz.org> > > Thanks, that looks fine to me. > > Acked-by: Simon Horman <horms@verge.net.au> Me too, applied to net-2.6.25, thanks Pavel.
creator: davem
date: 2007-11-20T06:53:00-00:00