Re: [PATCH] Remove write-only variable from pktgen_thread
Pavel Emelianov [xemul@openvz.org] wrote: | The pktgen_thread.pid is set to current->pid and is never used | after this. So remove this at all. | | Found during isolating the explicit pid/tgid usage. | | Signed-off-by: Pavel Emelyanov <xemul@openvz.org> Good observation that its not being used :-) Acked-by: Sukadev Bhattiprolu <sukadev@us.ibm.com> | | --- | | diff --git a/net/core/pktgen.c b/net/core/pktgen.c | index 3a3154e..93695c2 100644 | --- a/net/core/pktgen.c | +++ b/net/core/pktgen.c | @@ -380,7 +380,6 @@ struct pktgen_thread { | /* Field for thread to receive "posted" events terminate, stop ifs | etc. */ | | u32 control; | - int pid; | int cpu; | | wait_queue_head_t queue; | @@ -3462,8 +3461,6 @@ static int pktgen_thread_worker(void *ar | | init_waitqueue_head(&t->queue); | | - t->pid = current->pid; | - | pr_debug("pktgen: starting pktgen/%d: pid=%d\n", cpu, | task_pid_nr(current)); | | max_before_softirq = t->max_before_softirq; _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
From: sukadev@us.ibm.com Date: Wed, 29 Aug 2007 14:33:56 -0700 > Pavel Emelianov [xemul@openvz.org] wrote: > | The pktgen_thread.pid is set to current->pid and is never used > | after this. So remove this at all. > | > | Found during isolating the explicit pid/tgid usage. > | > | Signed-off-by: Pavel Emelyanov <xemul@openvz.org> > > Good observation that its not being used :-) > > Acked-by: Sukadev Bhattiprolu <sukadev@us.ibm.com> Patch applied, thanks. _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers