OpenVZ Forum - RDF feed
type: channel
items: [-mm PATCH 0/7] Memory controller introduction
items: [-mm PATCH 1/7] Memory controller resource counters
items: [-mm PATCH 2/7] Memory controller containers setup
items: [-mm PATCH 3/7] Memory controller accounting setup
items: [-mm PATCH 4/7] Memory controller memory accounting
items: [-mm PATCH 5/7] Memory controller task migration
items: [-mm PATCH 6/7] Memory controller add per container LRU and reclaim
items: [-mm PATCH 7/7] Memory controller OOM handling
items: Re: [-mm PATCH 0/7] Memory controller introduction
items: Re: [-mm PATCH 4/7] Memory controller memory accounting

[-mm PATCH 0/7] Memory controller introduction
type: item
description: Resending with the patch numbering fixed and linux-mm copied This patchset implements another version of the memory controller. These patches have been through a big churn, the first set of patches were posted last year and earlier this year at http://lkml.org/lkml/2007/2/19/10 Ever since, the RSS controller has been through four revisions, the latest one being http://lwn.net/Articles/236817/ This patchset draws from the patches listed above and from some of the contents of the patches posted by Vaidyanathan for page cache control. http://lkml.org/lkml/2007/6/20/92 Pavel, Vaidy could you look at the patches and add your signed off by where relevant? At OLS, the resource management BOF, it was discussed that we need to manage RSS and unmapped page cache together. This patchset is a step towards that TODO's 1. Add memory controller water mark support. Reclaim on high water mark 2. Add support for shrinking on limit change 3. Add per zone per container LRU lists 4. Make page_referenced() container aware 5. Figure out a better CLUI for the controller In case you have been using/testing the RSS controller, you'll find that this controller works slower than the RSS controller. The reason being that both swap cache and page cache is accounted for, so pages do go out to swap upon reclaim (they cannot live in the swap cache). I've test compiled the framework without the controller enabled, tested the code on UML and minimally on a power box. Any test output, feedback, comments, suggestions are welcome! series res_counters_infra.patch mem-control-setup.patch mem-control-accounting-setup.patch mem-control-accounting.patch mem-control-task-migration.patch mem-control-lru-and-reclaim.patch mem-control-out-of-memory.patch -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
creator: Balbir Singh
date: 2007-07-04T22:21:08-00:00

[-mm PATCH 1/7] Memory controller resource counters
type: item
description: Introduce generic structures and routines for resource accounting. Each resource accounting container is supposed to aggregate it, container_subsystem_state and its resource-specific members within. Signed-off-by: Pavel Emelianov <xemul@openvz.org> Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> --- include/linux/res_counter.h | 102 +++++++++++++++++++++++++++++++++++++ init/Kconfig | 4 + kernel/Makefile | 1 kernel/res_counter.c | 121 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 228 insertions(+) diff -puN /dev/null include/linux/res_counter.h --- /dev/null 2007-06-01 08:12:04.000000000 -0700 +++ linux-2.6.22-rc6-balbir/include/linux/res_counter.h 2007-07-04 15:05:19.000000000 -0700 @@ -0,0 +1,102 @@ +#ifndef __RES_COUNTER_H__ +#define __RES_COUNTER_H__ + +/* + * resource counters + * contain common data types and routines for resource accounting + * + * Copyright 2007 OpenVZ SWsoft Inc + * + * Author: Pavel Emelianov <xemul@openvz.org> + * + */ + +#include <linux/container.h> + +/* + * the core object. the container that wishes to account for some + * resource may include this counter into its structures and use + * the helpers described beyond + */ + +struct res_counter { + /* + * the current resource consumption level + */ + unsigned long usage; + /* + * the limit that usage cannot exceed + */ + unsigned long limit; + /* + * the number of insuccessful attempts to consume the resource + */ + unsigned long failcnt; + /* + * the lock to protect all of the above. + * the routines below consider this to be IRQ-safe + */ + spinlock_t lock; +}; + +/* + * helpers to interact with userspace + * res_counter_read/_write - put/get the specified fields from the + * res_counter struct to/from the user + * + * @cnt: the counter in question + * @member: the field to work with (see RES_xxx below) + * @buf: the buffer to opeate on,... + * @nbytes: its size... + * @pos: and the offset. + */ + +ssize_t res_counter_read(struct res_counter *cnt, int member, + …
creator: Balbir Singh
date: 2007-07-04T22:21:20-00:00

[-mm PATCH 2/7] Memory controller containers setup
type: item
description: Setup the memory container and add basic hooks and controls to integrate and work with the container. Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> --- include/linux/container_subsys.h | 6 + include/linux/memcontrol.h | 19 +++++ init/Kconfig | 8 ++ mm/Makefile | 1 mm/memcontrol.c | 141 +++++++++++++++++++++++++++++++++++++++ 5 files changed, 175 insertions(+) diff -puN include/linux/container_subsys.h~mem-control-setup include/linux/container_subsys.h --- linux-2.6.22-rc6/include/linux/container_subsys.h~mem-control-setup 2007-07-04 15:05:22.000000000 -0700 +++ linux-2.6.22-rc6-balbir/include/linux/container_subsys.h 2007-07-04 15:05:22.000000000 -0700 @@ -30,3 +30,9 @@ SUBSYS(ns) #endif /* */ + +#ifdef CONFIG_CONTAINER_MEM_CONT +SUBSYS(mem_container) +#endif + +/* */ diff -puN init/Kconfig~mem-control-setup init/Kconfig --- linux-2.6.22-rc6/init/Kconfig~mem-control-setup 2007-07-04 15:05:22.000000000 -0700 +++ linux-2.6.22-rc6-balbir/init/Kconfig 2007-07-04 15:05:22.000000000 -0700 @@ -360,6 +360,14 @@ config CONTAINER_NS for instance virtual servers and checkpoint/restart jobs. +config CONTAINER_MEM_CONT + bool "Memory controller for containers" + select CONTAINERS + select RESOURCE_COUNTERS + help + Provides a memory controller that manages both page cache and + RSS memory. + config PROC_PID_CPUSET bool "Include legacy /proc/<pid>/cpuset file" depends on CPUSETS diff -puN mm/Makefile~mem-control-setup mm/Makefile --- linux-2.6.22-rc6/mm/Makefile~mem-control-setup 2007-07-04 15:05:22.000000000 -0700 +++ linux-2.6.22-rc6-balbir/mm/Makefile 2007-07-04 15:05:22.000000000 -0700 @@ -30,4 +30,5 @@ obj-$(CONFIG_FS_XIP) += filemap_xip.o obj-$(CONFIG_MIGRATION) += migrate.o obj-$(CONFIG_SMP) += allocpercpu.o obj-$(CONFIG_QUICKLIST) += quicklist.o +obj-$(CONFIG_CONTAINER_MEM_CONT) += memcontrol.o diff -puN /dev/null mm/memcontrol.c --- /dev/null 2007-06-01 08:12:04.000000000 -0700 +++ linux-2.6.22-rc6-balbir/mm/memcontrol.c 2007-07-04 15:05:22.000000000 -0700 @@ -…
creator: Balbir Singh
date: 2007-07-04T22:21:35-00:00

[-mm PATCH 3/7] Memory controller accounting setup
type: item
description: Basic setup routines, the mm_struct has a pointer to the container that it belongs to and the the page has a meta_page associated with it. Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> --- include/linux/memcontrol.h | 32 ++++++++++++++++++++++++++++++ include/linux/mm_types.h | 4 +++ include/linux/sched.h | 4 +++ kernel/fork.c | 10 ++++++--- mm/memcontrol.c | 47 ++++++++++++++++++++++++++++++++++++++++++--- 5 files changed, 91 insertions(+), 6 deletions(-) diff -puN include/linux/memcontrol.h~mem-control-accounting-setup include/linux/memcontrol.h --- linux-2.6.22-rc6/include/linux/memcontrol.h~mem-control-accounting-setup 2007-07-04 15:05:24.000000000 -0700 +++ linux-2.6.22-rc6-balbir/include/linux/memcontrol.h 2007-07-04 15:05:24.000000000 -0700 @@ -15,5 +15,37 @@ #ifndef _LINUX_MEMCONTROL_H #define _LINUX_MEMCONTROL_H +struct mem_container; +struct meta_page; + +#ifdef CONFIG_CONTAINER_MEM_CONT + +extern void mm_init_container(struct mm_struct *mm, struct task_struct *p); +extern void mm_free_container(struct mm_struct *mm); +extern void page_assign_meta_page(struct page *page, struct meta_page *mp); +extern struct meta_page *page_get_meta_page(struct page *page); + +#else /* CONFIG_CONTAINER_MEM_CONT */ +static inline void mm_init_container(struct mm_struct *mm, + struct task_struct *p) +{ +} + +static inline void mm_free_container(struct mm_struct *mm) +{ +} + +static inline void page_assign_meta_page(struct page *page, + struct meta_page *mp) +{ +} + +static inline struct meta_page *page_get_meta_page(struct page *page) +{ + return NULL; +} + +#endif /* CONFIG_CONTAINER_MEM_CONT */ + #endif /* _LINUX_MEMCONTROL_H */ diff -puN include/linux/mm_types.h~mem-control-accounting-setup include/linux/mm_types.h --- linux-2.6.22-rc6/include/linux/mm_types.h~mem-control-accounting-setup 2007-07-04 15:05:24.000000000 -0700 +++ linux-2.6.22-rc6-balbir/include/linux/mm_types.h 2007-07-04 15:05:24.000000000 -0700 @@ -5,6 +5,7 @@ #include <linux/threads.h> #include…
creator: Balbir Singh
date: 2007-07-04T22:21:49-00:00

[-mm PATCH 4/7] Memory controller memory accounting
type: item
description: Add the accounting hooks. The accounting is carried out for RSS and Page Cache (unmapped) pages. There is now a common limit and accounting for both. The RSS accounting is accounted at page_add_*_rmap() and page_remove_rmap() time. Page cache is accounted at add_to_page_cache(), __delete_from_page_cache(). Swap cache is also accounted for. Each page's meta_page is protected with a bit in page flags, this makes handling of race conditions involving simultaneous mappings of a page easier. A reference count is kept in the meta_page to deal with cases where a page might be unmapped from the RSS of all tasks, but still lives in the page cache. Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> --- fs/exec.c | 1 include/linux/memcontrol.h | 11 +++ include/linux/page-flags.h | 3 + mm/filemap.c | 8 ++ mm/memcontrol.c | 132 ++++++++++++++++++++++++++++++++++++++++++++- mm/memory.c | 22 +++++++ mm/migrate.c | 6 ++ mm/page_alloc.c | 3 + mm/rmap.c | 2 mm/swap_state.c | 8 ++ mm/swapfile.c | 40 +++++++------ 11 files changed, 218 insertions(+), 18 deletions(-) diff -puN fs/exec.c~mem-control-accounting fs/exec.c --- linux-2.6.22-rc6/fs/exec.c~mem-control-accounting 2007-07-04 15:05:27.000000000 -0700 +++ linux-2.6.22-rc6-balbir/fs/exec.c 2007-07-04 15:05:27.000000000 -0700 @@ -51,6 +51,7 @@ #include <linux/cn_proc.h> #include <linux/audit.h> #include <linux/signalfd.h> +#include <linux/memcontrol.h> #include <asm/uaccess.h> #include <asm/mmu_context.h> diff -puN include/linux/memcontrol.h~mem-control-accounting include/linux/memcontrol.h --- linux-2.6.22-rc6/include/linux/memcontrol.h~mem-control-accounting 2007-07-04 15:05:27.000000000 -0700 +++ linux-2.6.22-rc6-balbir/include/linux/memcontrol.h 2007-07-04 15:05:27.000000000 -0700 @@ -24,6 +24,8 @@ extern void mm_init_container(struct mm_ extern void mm_free_container(struct mm_struct *mm); extern void page_assign_meta_page(struct page *page, struct meta_page *mp); extern struct meta_page *page_get_meta_page(struct page *pa…
creator: Balbir Singh
date: 2007-07-04T22:22:03-00:00

[-mm PATCH 5/7] Memory controller task migration
type: item
description: Allow tasks to migrate from one container to the other. We migrate mm_struct's mem_container only when the thread group id migrates. Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> --- mm/memcontrol.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff -puN mm/memcontrol.c~mem-control-task-migration mm/memcontrol.c --- linux-2.6.22-rc6/mm/memcontrol.c~mem-control-task-migration 2007-07-04 15:05:29.000000000 -0700 +++ linux-2.6.22-rc6-balbir/mm/memcontrol.c 2007-07-04 15:05:29.000000000 -0700 @@ -302,11 +302,46 @@ err: return rc; } +static void mem_container_move_task(struct container_subsys *ss, + struct container *cont, + struct container *old_cont, + struct task_struct *p) +{ + struct mm_struct *mm; + struct mem_container *mem, *old_mem; + + mm = get_task_mm(p); + if (mm == NULL) + return; + + mem = mem_container_from_cont(cont); + old_mem = mem_container_from_cont(old_cont); + + if (mem == old_mem) + goto out; + + /* + * Only thread group leaders are allowed to migrate, the mm_struct is + * in effect owned by the leader + */ + if (p->tgid != p->pid) + goto out; + + css_get(&mem->css); + rcu_assign_pointer(mm->mem_container, mem); + css_put(&old_mem->css); + +out: + mmput(mm); + return; +} + struct container_subsys mem_container_subsys = { .name = "mem_container", .subsys_id = mem_container_subsys_id, .create = mem_container_create, .destroy = mem_container_destroy, .populate = mem_container_populate, + .attach = mem_container_move_task, .early_init = 1, }; _ -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
creator: Balbir Singh
date: 2007-07-04T22:22:21-00:00

[-mm PATCH 6/7] Memory controller add per container LRU and reclaim
type: item
description: Add the meta_page to the per container LRU. The reclaim algorithm has been modified to make the isolate_lru_pages() as a pluggable component. The scan_control data structure now accepts the container on behalf of which reclaims are carried out. try_to_free_pages() has been extended to become container aware. Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> --- include/linux/memcontrol.h | 11 +++ include/linux/res_counter.h | 23 +++++++ include/linux/swap.h | 3 + mm/memcontrol.c | 88 +++++++++++++++++++++++++++++- mm/swap.c | 2 mm/vmscan.c | 129 +++++++++++++++++++++++++++++++++++--------- 6 files changed, 230 insertions(+), 26 deletions(-) diff -puN include/linux/memcontrol.h~mem-control-lru-and-reclaim include/linux/memcontrol.h --- linux-2.6.22-rc6/include/linux/memcontrol.h~mem-control-lru-and-reclaim 2007-07-04 15:05:31.000000000 -0700 +++ linux-2.6.22-rc6-balbir/include/linux/memcontrol.h 2007-07-04 15:05:31.000000000 -0700 @@ -26,6 +26,13 @@ extern void page_assign_meta_page(struct extern struct meta_page *page_get_meta_page(struct page *page); extern int mem_container_charge(struct page *page, struct mm_struct *mm); extern void mem_container_uncharge(struct meta_page *mp); +extern void mem_container_move_lists(struct meta_page *mp, bool active); +extern unsigned long mem_container_isolate_pages(unsigned long nr_to_scan, + struct list_head *dst, + unsigned long *scanned, int order, + int mode, struct zone *z, + struct mem_container *mem_cont, + int active); #else /* CONFIG_CONTAINER_MEM_CONT */ static inline void mm_init_container(struct mm_struct *mm, @@ -56,6 +63,10 @@ static inline void mem_container_uncharg { } +static inline void mem_container_move_lists(struct meta_page *mp, bool active) +{ +} + #endif /* CONFIG_CONTAINER_MEM_CONT */ #endif /* _LINUX_MEMCONTROL_H */ diff -puN include/linux/swap.h~mem-control-lru-and-reclaim include/linux/swap.h --- linux-2.6.22-rc6/include/linux/swap.h~mem-control-lru-and-reclaim 2007-07-04 15:05:31.000000000 -070…
creator: Balbir Singh
date: 2007-07-04T22:22:34-00:00

[-mm PATCH 7/7] Memory controller OOM handling
type: item
description: Out of memory handling for containers over their limit. A task from the container over limit is chosen using the existing OOM logic and killed. TODO: 1. As discussed in the OLS BOF session, consider implementing a user space policy for OOM handling. Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> --- include/linux/memcontrol.h | 1 + mm/memcontrol.c | 1 + mm/oom_kill.c | 42 ++++++++++++++++++++++++++++++++++++++---- 3 files changed, 40 insertions(+), 4 deletions(-) diff -puN include/linux/memcontrol.h~mem-control-out-of-memory include/linux/memcontrol.h --- linux-2.6.22-rc6/include/linux/memcontrol.h~mem-control-out-of-memory 2007-07-04 15:05:34.000000000 -0700 +++ linux-2.6.22-rc6-balbir/include/linux/memcontrol.h 2007-07-04 15:05:34.000000000 -0700 @@ -33,6 +33,7 @@ extern unsigned long mem_container_isola int mode, struct zone *z, struct mem_container *mem_cont, int active); +extern void mem_cont_out_of_memory(struct mem_container *mem); #else /* CONFIG_CONTAINER_MEM_CONT */ static inline void mm_init_container(struct mm_struct *mm, diff -puN mm/memcontrol.c~mem-control-out-of-memory mm/memcontrol.c --- linux-2.6.22-rc6/mm/memcontrol.c~mem-control-out-of-memory 2007-07-04 15:05:34.000000000 -0700 +++ linux-2.6.22-rc6-balbir/mm/memcontrol.c 2007-07-04 15:05:34.000000000 -0700 @@ -240,6 +240,7 @@ int mem_container_charge(struct page *pa if (res_counter_check_under_limit(&mem->res)) continue; + mem_cont_out_of_memory(mem); goto free_mp; } diff -puN mm/oom_kill.c~mem-control-out-of-memory mm/oom_kill.c --- linux-2.6.22-rc6/mm/oom_kill.c~mem-control-out-of-memory 2007-07-04 15:05:34.000000000 -0700 +++ linux-2.6.22-rc6-balbir/mm/oom_kill.c 2007-07-04 15:05:34.000000000 -0700 @@ -24,6 +24,7 @@ #include <linux/cpuset.h> #include <linux/module.h> #include <linux/notifier.h> +#include <linux/memcontrol.h> int sysctl_panic_on_oom; /* #define DEBUG */ @@ -47,7 +48,8 @@ int sysctl_panic_on_oom; * of least surprise ... (be careful when you change it) */ -unsigned long …
creator: Balbir Singh
date: 2007-07-04T22:22:53-00:00

Re: [-mm PATCH 0/7] Memory controller introduction
type: item
description: Balbir Singh wrote: > Resending with the patch numbering fixed and linux-mm copied > > This patchset implements another version of the memory controller. These > patches have been through a big churn, the first set of patches were posted > last year and earlier this year at > http://lkml.org/lkml/2007/2/19/10 > > Ever since, the RSS controller has been through four revisions, the latest > one being > http://lwn.net/Articles/236817/ > > This patchset draws from the patches listed above and from some of the > contents of the patches posted by Vaidyanathan for page cache control. > http://lkml.org/lkml/2007/6/20/92 > > Pavel, Vaidy could you look at the patches and add your signed off by > where relevant? As far as I remember at OLS we decided to implement per-zone RLU lists and reuse the lru lock as well. This will remove all the problems with per-container lists inconsistency. Separate limits for RSS and RSS+pagecache are also a must. BTW, if you send smb. else's patches you may include a 'From: xxx' line into the letter to address the original author. > At OLS, the resource management BOF, it was discussed that we need to manage > RSS and unmapped page cache together. This patchset is a step towards that > > TODO's > > 1. Add memory controller water mark support. Reclaim on high water mark > 2. Add support for shrinking on limit change > 3. Add per zone per container LRU lists > 4. Make page_referenced() container aware > 5. Figure out a better CLUI for the controller > > In case you have been using/testing the RSS controller, you'll find that > this controller works slower than the RSS controller. The reason being > that both swap cache and page cache is accounted for, so pages do go > out to swap upon reclaim (they cannot live in the swap cache). > > I've test compiled the framework without the controller enabled, tested > the code on UML and minimally on a power box. > > Any test output, feedback, comments, suggestions are welcome! > > series > > res_counters_inf…
creator: Pavel Emelianov
date: 2007-07-05T09:14:00-00:00

Re: [-mm PATCH 0/7] Memory controller introduction
type: item
description: Hi, Pavel, Pavel Emelianov wrote: > Balbir Singh wrote: > > As far as I remember at OLS we decided to implement per-zone RLU > lists and reuse the lru lock as well. This will remove all the > problems with per-container lists inconsistency. > It's there in the TODO list. It is easy to implement. I can do that in the next revision. We are re-using the LRU lock, since the isolate_pages callback is called under the zone's LRU lock. > Separate limits for RSS and RSS+pagecache are also a must. > I remember that we discussed having one limit, but we can come up with a configuration parameter to do it. I'll do that in the next release. > BTW, if you send smb. else's patches you may include a 'From: xxx' > line into the letter to address the original author. > I'll do that for the res_counters_infra patch. Although I had used res_counter, the hooks in mm_struct earlier (http://lkml.org/lkml/2007/2/19/12). A lot of the code for the reclaim logic and the meta_page is yours. Please do identify patches where you would like to see your signed-off-by and where you think the entire patch is completely yours. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
creator: Balbir Singh
date: 2007-07-05T14:32:31-00:00

Re: [-mm PATCH 4/7] Memory controller memory accounting
type: item
description: Balbir Singh wrote: > Add the accounting hooks. The accounting is carried out for RSS and Page > Cache (unmapped) pages. There is now a common limit and accounting for both. > The RSS accounting is accounted at page_add_*_rmap() and page_remove_rmap() > time. Page cache is accounted at add_to_page_cache(), > __delete_from_page_cache(). Swap cache is also accounted for. > > Each page's meta_page is protected with a bit in page flags, this makes > handling of race conditions involving simultaneous mappings of a page easier. > A reference count is kept in the meta_page to deal with cases where a page > might be unmapped from the RSS of all tasks, but still lives in the page > cache. > > Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> > --- > > fs/exec.c | 1 > include/linux/memcontrol.h | 11 +++ > include/linux/page-flags.h | 3 + > mm/filemap.c | 8 ++ > mm/memcontrol.c | 132 ++++++++++++++++++++++++++++++++++++++++++++- > mm/memory.c | 22 +++++++ > mm/migrate.c | 6 ++ > mm/page_alloc.c | 3 + > mm/rmap.c | 2 > mm/swap_state.c | 8 ++ > mm/swapfile.c | 40 +++++++------ > 11 files changed, 218 insertions(+), 18 deletions(-) > [snip] > diff -puN mm/migrate.c~mem-control-accounting mm/migrate.c > --- linux-2.6.22-rc6/mm/migrate.c~mem-control-accounting 2007-07-04 15:05:27.000000000 -0700 > +++ linux-2.6.22-rc6-balbir/mm/migrate.c 2007-07-04 15:05:27.000000000 -0700 > @@ -28,6 +28,7 @@ > #include <linux/mempolicy.h> > #include <linux/vmalloc.h> > #include <linux/security.h> > +#include <linux/memcontrol.h> > > #include "internal.h" > > @@ -157,6 +158,11 @@ static void remove_migration_pte(struct > return; > } > > + if (mem_container_charge(page, mm)) { Minor correction. The above line should be if (mem_container_charge(new, mm)) { to avoid compilation error. --Vaidy [snip] _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
creator: Vaidyanathan Srinivas
date: 2007-07-05T18:46:04-00:00

Re: [-mm PATCH 4/7] Memory controller memory accounting
type: item
description: Vaidyanathan Srinivasan wrote: >> >> + if (mem_container_charge(page, mm)) { > > Minor correction. The above line should be > > if (mem_container_charge(new, mm)) { > > to avoid compilation error. > > --Vaidy > > [snip] Thanks, Vaidy, Patch incorporated. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
creator: Balbir Singh
date: 2007-07-05T20:03:22-00:00

Re: [-mm PATCH 0/7] Memory controller introduction
type: item
description: On Thu, 2007-07-05 at 13:14 +0400, Pavel Emelianov wrote: > Separate limits for RSS and RSS+pagecache are also a must. This I still disagree upon. Page-cache limits are orthogonal to containers and not a requirement for containers. If you want such a feature get it in Linux proper and don't sneak it in the backdoor via containers. _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
creator: Peter Zijlstra
date: 2007-07-06T13:14:50-00:00

Re: [-mm PATCH 0/7] Memory controller introduction
type: item
description: Peter Zijlstra wrote: > On Thu, 2007-07-05 at 13:14 +0400, Pavel Emelianov wrote: > >> Separate limits for RSS and RSS+pagecache are also a must. > > This I still disagree upon. Page-cache limits are orthogonal to > containers and not a requirement for containers. If you want such a > feature get it in Linux proper and don't sneak it in the backdoor via > containers. What I wanted to say is that *iff* we need limit for booth the RSS and the page cache, then we do need a separate limit for the RSS only. I do not vote for the page cache limit either, but I do not vote _against_ it as well, and agree to take part in its development. Thanks, Pavel. _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
creator: Pavel Emelianov
date: 2007-07-06T14:06:52-00:00

Re: [-mm PATCH 0/7] Memory controller introduction
type: item
description: Peter Zijlstra wrote: > On Thu, 2007-07-05 at 13:14 +0400, Pavel Emelianov wrote: > >> Separate limits for RSS and RSS+pagecache are also a must. > > This I still disagree upon. Page-cache limits are orthogonal to > containers and not a requirement for containers. If you want such a > feature get it in Linux proper and don't sneak it in the backdoor via > containers. > > > Peter, In these patches, we provide memory control that includes mapped pages and unmapped pages (as discussed in the BOF). All memory is treated uniformly. We will not have separate page cache control, what we can have is control for either mapped pages or control for a combination of mapped and unmapped pages together. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers
creator: Balbir Singh
date: 2007-07-06T15:34:27-00:00