OpenVZ Forum - RDF feed
type: channel
items: pspace name
items: Re: pspace name

pspace name
type: item
description: all, 'pspace' sounds wrong when you know about the other namespaces : struct nsproxy { atomic_t count; spinlock_t nslock; struct uts_namespace *uts_ns; struct ipc_namespace *ipc_ns; struct user_namespace *user_ns; struct namespace *namespace; }; 'proc_namespace' might be confusing, what about 'task_namespace' ? 'namespace' should probably be renamed to something like 'mnt_namespace' ? C. _______________________________________________ Containers mailing list Containers@lists.osdl.org https://lists.osdl.org/mailman/listinfo/containers
creator: Cedric Le Goater
date: 2006-09-07T13:22:30-00:00

Re: pspace name
type: item
description: Cedric Le Goater wrote: > all, > > 'pspace' sounds wrong when you know about the other namespaces : > > struct nsproxy { > atomic_t count; > spinlock_t nslock; > struct uts_namespace *uts_ns; > struct ipc_namespace *ipc_ns; > struct user_namespace *user_ns; > struct namespace *namespace; > }; > > 'proc_namespace' might be confusing, what about 'task_namespace' ? yes, I also wanted to point to this, but probably missed in a hurry. task_ns/task_namespace looks fine, doesn't it? > 'namespace' should probably be renamed to something like 'mnt_namespace' ? struct: mnt_namespace fields: mnt_ns is the patch below ok for you? --- --- ./fs/afs/mntpt.c.mntr 2006-07-14 19:08:29.000000000 +0400 +++ ./fs/afs/mntpt.c 2006-09-07 18:47:27.000000000 +0400 @@ -18,7 +18,7 @@ #include <linux/pagemap.h> #include <linux/mount.h> #include <linux/namei.h> -#include <linux/namespace.h> +#include <linux/mnt_namespace.h> #include "super.h" #include "cell.h" #include "volume.h" --- ./fs/namespace.c.mntr 2006-07-14 19:11:05.000000000 +0400 +++ ./fs/namespace.c 2006-09-07 19:28:05.000000000 +0400 @@ -20,7 +20,7 @@ #include <linux/module.h> #include <linux/sysfs.h> #include <linux/seq_file.h> -#include <linux/namespace.h> +#include <linux/mnt_namespace.h> #include <linux/namei.h> #include <linux/security.h> #include <linux/mount.h> @@ -134,10 +134,10 @@ struct vfsmount *lookup_mnt(struct vfsmo static inline int check_mnt(struct vfsmount *mnt) { - return mnt->mnt_namespace == current->nsproxy->namespace; + return mnt->mnt_ns == current->nsproxy->mnt_ns; } -static void touch_namespace(struct namespace *ns) +static void touch_mnt_namespace(struct mnt_namespace *ns) { if (ns) { ns->event = ++event; @@ -145,7 +145,7 @@ static void touch_namespace(struct names } } -static void __touch_namespace(struct namespace *ns) +static void __touch_mnt_namespace(struct mnt_namespace *ns) { if (ns && ns->event != event) { ns->event = event; @@ -188,19 +188,19 @@ static void commit_tree(struct vfsmount struct vfsmou…
creator: dev
date: 2006-09-07T15:36:07-00:00

Re: pspace name
type: item
description: On Thu, Sep 07, 2006 at 03:22:30PM +0200, Cedric Le Goater wrote: > all, > > 'pspace' sounds wrong when you know about the other namespaces : > > struct nsproxy { > atomic_t count; > spinlock_t nslock; > struct uts_namespace *uts_ns; > struct ipc_namespace *ipc_ns; > struct user_namespace *user_ns; > struct namespace *namespace; > }; > > 'proc_namespace' might be confusing, what about 'task_namespace' ? > > 'namespace' should probably be renamed to something like 'mnt_namespace' ? what about vfs_namespace? just an idea, best, Herbert > > C. > _______________________________________________ > Containers mailing list > Containers@lists.osdl.org > https://lists.osdl.org/mailman/listinfo/containers _______________________________________________ Containers mailing list Containers@lists.osdl.org https://lists.osdl.org/mailman/listinfo/containers
creator: Herbert Poetzl
date: 2006-09-07T15:43:01-00:00

Re: pspace name
type: item
description: Herbert Poetzl wrote: > On Thu, Sep 07, 2006 at 03:22:30PM +0200, Cedric Le Goater wrote: > >>all, >> >>'pspace' sounds wrong when you know about the other namespaces : >> >>struct nsproxy { >> atomic_t count; >> spinlock_t nslock; >> struct uts_namespace *uts_ns; >> struct ipc_namespace *ipc_ns; >> struct user_namespace *user_ns; >> struct namespace *namespace; >>}; >> >>'proc_namespace' might be confusing, what about 'task_namespace' ? >> >>'namespace' should probably be renamed to something like 'mnt_namespace' ? > > > what about vfs_namespace? imho later we will need introduce fs namespace etc. at least I see additional fs_namespace which allows to control which filesystems are visible in the context. And such fs_namespace should be separate from mnt_namespace. Kirill _______________________________________________ Containers mailing list Containers@lists.osdl.org https://lists.osdl.org/mailman/listinfo/containers
creator: dev
date: 2006-09-07T16:11:57-00:00

Re: pspace name
type: item
description: Kirill Korotaev wrote: > Cedric Le Goater wrote: >> all, >> >> 'pspace' sounds wrong when you know about the other namespaces : >> >> struct nsproxy { >> atomic_t count; >> spinlock_t nslock; >> struct uts_namespace *uts_ns; >> struct ipc_namespace *ipc_ns; >> struct user_namespace *user_ns; >> struct namespace *namespace; >> }; >> >> 'proc_namespace' might be confusing, what about 'task_namespace' ? > yes, I also wanted to point to this, but probably missed in a hurry. > task_ns/task_namespace looks fine, doesn't it? > >> 'namespace' should probably be renamed to something like >> 'mnt_namespace' ? > struct: mnt_namespace > fields: mnt_ns > > is the patch below ok for you? yep. touch_mnt_namespace() and the namespace_sem could be renamed but they are private to namespace.c, so no big issue. here's a port of your patchset for 2.6.18-rc6 which could be used before -mm ? thanks, C. this patch renames 'struct namespace' to 'struct mnt_namespace' and 'namespace' variables to 'mnt_ns' to avoid confusion with other namespaces being developped for the containers. Signed-off-by: Cedric Le Goater <clg@fr.ibm.com> Cc: containers@lists.osdl.org --- fs/afs/mntpt.c | 2 fs/namespace.c | 112 +++++++++++++++++++++--------------------- fs/pnode.c | 2 fs/pnode.h | 2 fs/proc/base.c | 36 ++++++------- fs/reiserfs/super.c | 2 include/linux/mnt_namespace.h | 41 +++++++++++++++ include/linux/mount.h | 4 - include/linux/namespace.h | 44 ---------------- include/linux/sched.h | 6 +- kernel/exit.c | 10 +-- kernel/fork.c | 32 ++++++------ kernel/kmod.c | 2 13 files changed, 147 insertions(+), 148 deletions(-) Index: 2.6.18-rc6/fs/afs/mntpt.c =================================================================== --- 2.6.18-rc6.orig/fs/afs/mntpt.c +++ 2.6.18-rc6/fs/afs/mntpt.c @@ -18,7 +18,7 @@ #include <linux/pagemap.h> #include <linux/mount.h> #include <linux/namei.h> -#include <linux/namespace.h> +#include <linux/mnt_namespace.h> #include "super.h" #include "cell.h" #include "volume.h" Index: 2…
creator: Cedric Le Goater
date: 2006-09-07T21:16:58-00:00

Re: pspace name
type: item
description: Cedric, >>>'namespace' should probably be renamed to something like >>>'mnt_namespace' ? >> >>struct: mnt_namespace >>fields: mnt_ns >> >>is the patch below ok for you? > > > yep. > > touch_mnt_namespace() and the namespace_sem could be renamed but they are > private to namespace.c, so no big issue. here's a port of your patchset for > 2.6.18-rc6 which could be used before -mm ? do you think we need to send it to Linus to 2.6.18-rc6? I think we should keep sending such changes to -mm IMHO... Thanks, Kirill > thanks, > > C. > > > > this patch renames 'struct namespace' to 'struct mnt_namespace' and > 'namespace' variables to 'mnt_ns' to avoid confusion with other > namespaces being developped for the containers. > > > Signed-off-by: Cedric Le Goater <clg@fr.ibm.com> > Cc: containers@lists.osdl.org > > --- > fs/afs/mntpt.c | 2 > fs/namespace.c | 112 > +++++++++++++++++++++--------------------- > fs/pnode.c | 2 > fs/pnode.h | 2 > fs/proc/base.c | 36 ++++++------- > fs/reiserfs/super.c | 2 > include/linux/mnt_namespace.h | 41 +++++++++++++++ > include/linux/mount.h | 4 - > include/linux/namespace.h | 44 ---------------- > include/linux/sched.h | 6 +- > kernel/exit.c | 10 +-- > kernel/fork.c | 32 ++++++------ > kernel/kmod.c | 2 > 13 files changed, 147 insertions(+), 148 deletions(-) > > Index: 2.6.18-rc6/fs/afs/mntpt.c > =================================================================== > --- 2.6.18-rc6.orig/fs/afs/mntpt.c > +++ 2.6.18-rc6/fs/afs/mntpt.c > @@ -18,7 +18,7 @@ > #include <linux/pagemap.h> > #include <linux/mount.h> > #include <linux/namei.h> > -#include <linux/namespace.h> > +#include <linux/mnt_namespace.h> > #include "super.h" > #include "cell.h" > #include "volume.h" > Index: 2.6.18-rc6/fs/namespace.c > =================================================================== > --- 2.6.18-rc6.orig/fs/namespace.c > +++ 2.6.18-rc6/fs/namespace.c > @@ -18,7 +18,7 @@ > #include <linux/capability.h> > #include <linux/module.h> > #include <linux/seq_file.h> > -#in…
creator: dev
date: 2006-09-08T15:30:53-00:00

Re: pspace name
type: item
description: On Thu, 2006-09-07 at 15:22 +0200, Cedric Le Goater wrote: > all, > > 'pspace' sounds wrong when you know about the other namespaces : Yeah, I agree. > struct nsproxy { > atomic_t count; > spinlock_t nslock; > struct uts_namespace *uts_ns; > struct ipc_namespace *ipc_ns; > struct user_namespace *user_ns; > struct namespace *namespace; > }; > > 'proc_namespace' might be confusing, what about 'task_namespace' ? task_ might do. I don't have any better ideas. > 'namespace' should probably be renamed to something like 'mnt_namespace' ? fs_namespace? This is probably a "do a patch and CC Viro" kind of thing. -- Dave _______________________________________________ Containers mailing list Containers@lists.osdl.org https://lists.osdl.org/mailman/listinfo/containers
creator: Dave Hansen
date: 2006-09-08T16:02:37-00:00

Re: pspace name
type: item
description: On Thu, 2006-09-07 at 20:11 +0400, Kirill Korotaev wrote: > imho later we will need introduce fs namespace etc. > at least I see additional fs_namespace which allows to control which > filesystems are visible > in the context. And such fs_namespace should be separate from > mnt_namespace. Could you elaborate on this a bit? -- Dave _______________________________________________ Containers mailing list Containers@lists.osdl.org https://lists.osdl.org/mailman/listinfo/containers
creator: Dave Hansen
date: 2006-09-08T20:24:46-00:00

Re: pspace name
type: item
description: Dave Hansen wrote: > On Thu, 2006-09-07 at 20:11 +0400, Kirill Korotaev wrote: > >>imho later we will need introduce fs namespace etc. >>at least I see additional fs_namespace which allows to control which >>filesystems are visible >>in the context. And such fs_namespace should be separate from >>mnt_namespace. > > > Could you elaborate on this a bit? I wrote it in another email to Eric: proc-ns, sysfs-ns, printk-ns or syslog-ns?: syslog should be virtualized and more... semi-namespaces: fs-ns (should regulate which filesystems are accessiable from container, but probably this is not exact name space... need to think over...), dev-ns (should regulate which devices are accessiable from container) Kirill _______________________________________________ Containers mailing list Containers@lists.osdl.org https://lists.osdl.org/mailman/listinfo/containers
creator: dev
date: 2006-09-12T14:43:23-00:00