Re: [PATCH] fs: fix dentry leak in simple_fill_super()
On Tue 01-11-11 16:12:33, Konstantin Khlebnikov wrote: > put dentry if inode allocation failed, d_genocide() cannot release it Al is currently ill and Christoph Hellwig is taking care of fixes for now. Added him to CC... Honza > > Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org> > --- > fs/libfs.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/fs/libfs.c b/fs/libfs.c > index c18e9a1..a2c0029 100644 > --- a/fs/libfs.c > +++ b/fs/libfs.c > @@ -510,8 +510,10 @@ int simple_fill_super(struct super_block *s, unsigned long magic, > if (!dentry) > goto out; > inode = new_inode(s); > - if (!inode) > + if (!inode) { > + dput(dentry); > goto out; > + } > inode->i_mode = S_IFREG | files->mode; > inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; > inode->i_fop = files->ops; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara <jack@suse.cz> SUSE Labs, CR