OpenVZ Forum - RDF feed
type: channel
items: [PATCH v2 0/4] Series short description
items: [PATCH v2 3/4] SUNRPC: optimize net_ns dereferencing in rpcbind creation calls
items: [PATCH v2 4/4] SUNRPC: optimize net_ns dereferencing in rpcbind registering calls
items: Re: [PATCH v2 0/4] Series short description

[PATCH v2 0/4] Series short description
type: item
description: This patch-set was created in context of clone of git branch: git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git and rebased on tag "v3.1". This patch-set virtualizes rpcbind clients per network namespace context. IOW, each network namespace will have its own pair of rpcbind clients (if the would be created by request). Note: 1) this patch-set depends on "SUNRPC: make rpcbind clients allocated and destroyed dynamically" patch-set which has been send earlier. 2) init_net pointer is still used instead of current->nsproxy->net_ns, because I'm not sure yet about how to virtualize services. I.e. NFS callback services will be per netns. NFSd service will be per netns too from my pow. But Lockd can be per netns or one for all. And also we have NFSd file system, which is not virtualized yet. The following series consists of: --- Stanislav Kinsbursky (4): SUNRPC: rpcbind clients internals virtualization SUNRPC: use virtualized rpcbind internals instead of static ones SUNRPC: optimize net_ns dereferencing in rpcbind creation calls SUNRPC: optimize net_ns dereferencing in rpcbind registering calls net/sunrpc/netns.h | 5 ++ net/sunrpc/rpcb_clnt.c | 103 ++++++++++++++++++++++++++---------------------- 2 files changed, 61 insertions(+), 47 deletions(-) -- Signature
creator: Stanislav Kinsbursky
date: 2011-10-25T13:59:42-00:00

[PATCH v2 3/4] SUNRPC: optimize net_ns dereferencing in rpcbind creation calls
type: item
description: Static rpcbind creation functions can be parametrized by network namespace pointer, calculated only once, instead of using init_net pointer (or taking it from current when virtualization will be comleted) in many places. Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com> --- net/sunrpc/rpcb_clnt.c | 35 +++++++++++++++++++---------------- 1 files changed, 19 insertions(+), 16 deletions(-) diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c index 18eba8e..ef37c55 100644 --- a/net/sunrpc/rpcb_clnt.c +++ b/net/sunrpc/rpcb_clnt.c @@ -161,10 +161,10 @@ static void rpcb_map_release(void *data) kfree(map); } -static int rpcb_get_local(void) +static int rpcb_get_local(struct net *net) { int cnt; - struct sunrpc_net *sn = net_generic(&init_net, sunrpc_net_id); + struct sunrpc_net *sn = net_generic(net, sunrpc_net_id); spin_lock(&sn->rpcb_clnt_lock); if (sn->rpcb_users) @@ -202,9 +202,10 @@ void rpcb_put_local(void) return; } -static void rpcb_set_local(struct rpc_clnt *clnt, struct rpc_clnt *clnt4) +static void rpcb_set_local(struct net *net, struct rpc_clnt *clnt, + struct rpc_clnt *clnt4) { - struct sunrpc_net *sn = net_generic(&init_net, sunrpc_net_id); + struct sunrpc_net *sn = net_generic(net, sunrpc_net_id); /* Protected by rpcb_create_local_mutex */ sn->rpcb_local_clnt = clnt; @@ -212,22 +213,23 @@ static void rpcb_set_local(struct rpc_clnt *clnt, struct rpc_clnt *clnt4) smp_wmb(); sn->rpcb_users = 1; dprintk("RPC: created new rpcb local clients (rpcb_local_clnt: " - "%p, rpcb_local_clnt4: %p)\n", sn->rpcb_local_clnt, - sn->rpcb_local_clnt4); + "%p, rpcb_local_clnt4: %p) for net %p%s\n", + sn->rpcb_local_clnt, sn->rpcb_local_clnt4, + net, (net == &init_net) ? " (init_net)" : ""); } /* * Returns zero on success, otherwise a negative errno value * is returned. */ -static int rpcb_create_local_unix(void) +static int rpcb_create_local_unix(struct net *net) { static const struct sockaddr_un rpcb_localaddr_rpcbind = { .sun_family = AF_LOCAL, .sun_path =…
creator: Stanislav Kinsbursky
date: 2011-10-25T13:59:46-00:00

[PATCH v2 4/4] SUNRPC: optimize net_ns dereferencing in rpcbind registering calls
type: item
description: Static rpcbind registering functions can be parametrized by network namespace pointer, calculated only once, instead of using init_net pointer (or taking it from current when virtualization will be comleted) in many places. Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com> --- net/sunrpc/rpcb_clnt.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c index ef37c55..92ed74f 100644 --- a/net/sunrpc/rpcb_clnt.c +++ b/net/sunrpc/rpcb_clnt.c @@ -452,14 +452,14 @@ int rpcb_register(u32 prog, u32 vers, int prot, unsigned short port) /* * Fill in AF_INET family-specific arguments to register */ -static int rpcb_register_inet4(const struct sockaddr *sap, +static int rpcb_register_inet4(struct sunrpc_net *sn, + const struct sockaddr *sap, struct rpc_message *msg) { const struct sockaddr_in *sin = (const struct sockaddr_in *)sap; struct rpcbind_args *map = msg->rpc_argp; unsigned short port = ntohs(sin->sin_port); int result; - struct sunrpc_net *sn = net_generic(&init_net, sunrpc_net_id); map->r_addr = rpc_sockaddr2uaddr(sap); @@ -480,14 +480,14 @@ static int rpcb_register_inet4(const struct sockaddr *sap, /* * Fill in AF_INET6 family-specific arguments to register */ -static int rpcb_register_inet6(const struct sockaddr *sap, +static int rpcb_register_inet6(struct sunrpc_net *sn, + const struct sockaddr *sap, struct rpc_message *msg) { const struct sockaddr_in6 *sin6 = (const struct sockaddr_in6 *)sap; struct rpcbind_args *map = msg->rpc_argp; unsigned short port = ntohs(sin6->sin6_port); int result; - struct sunrpc_net *sn = net_generic(&init_net, sunrpc_net_id); map->r_addr = rpc_sockaddr2uaddr(sap); @@ -505,10 +505,10 @@ static int rpcb_register_inet6(const struct sockaddr *sap, return result; } -static int rpcb_unregister_all_protofamilies(struct rpc_message *msg) +static int rpcb_unregister_all_protofamilies(struct sunrpc_net *sn, + struct rpc_message *msg) { struct rpcbind_a…
creator: Stanislav Kinsbursky
date: 2011-10-25T13:59:48-00:00

Re: [PATCH v2 0/4] Series short description
type: item
description: Sorry for dummy series description. Here is the right one: "[PATCH v2 0/4] SUNRPC: rcbind clients virtualization" -- Best regards, Stanislav Kinsbursky
creator: Stanislav Kinsbursky
date: 2011-10-25T14:20:59-00:00